Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: update WordPress version requirements to WP 5.6 #18860

Merged
merged 14 commits into from
Feb 23, 2021
Merged

General: update WordPress version requirements to WP 5.6 #18860

merged 14 commits into from
Feb 23, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 17, 2021 •
edited
Loading

Changes proposed in this Pull Request:

WordPress 5.7 will be released on March 9, 2021, and from that point on Jetpack will require WP 5.6.

This PR introduces the following changes:

  • Update our "tested up to" version
  • Update the version of WordPress required for Jetpack from WP 5.5 to WP 5.6
  • Changes to Toolbar components (Reference)
  • Move away from IconButton (Reference)
  • Move from formattingControls to allowedFormats (Reference)
  • Other block deprecations

Jetpack product discussion

Primary issue: #18842

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Do the tests pass?
  • Test all the blocks that were updated in this PR (see labels), and ensure they still work. You'll want to pay extra attention to the block toolbars that appear above each block.

Proposed changelog entry for your changes:

  • General: Jetpack now requires WordPress 5.6, and is fully compatible with WordPress 5.7.

@jeherve
General: update WordPress version requirements to WP 5.6
3047bdd 
WordPress 5.7 will be released on March 9, 2021, and from that point on Jetpack will require WP 5.6.
See #18842
@jeherve jeherve added this to the 9.5 milestone Feb 17, 2021
@jeherve jeherve self-assigned this Feb 17, 2021
@jeherve jeherve mentioned this pull request Feb 17, 2021
Closed
11 tasks
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Actions GitHub actions used to automate some of the work around releases and repository management labels Feb 17, 2021
@jetpackbot
Copy link

jetpackbot commented Feb 17, 2021 •
edited
Loading

Scheduled Jetpack release: March 2, 2021.
Scheduled code freeze: February 22, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 5065a7d

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D57219-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve
Publicize: Remove test for old Twitter block
343d2fe 
Since we do not support the old Twitter block, let's remove the test for it.

Support was removed in 5065a7d
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Include a changelog entry for any meaningful change.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

jetpack plugin:

  • Next scheduled release: March 2, 2021.
  • Scheduled code freeze: February 22, 2021

anomiex
anomiex previously approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Haven't manually tested though.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 22, 2021
@anomiex
Copy link
Contributor

anomiex commented Feb 22, 2021

JS tests are failing again.

@anomiex anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 22, 2021
@jeherve
Update to a version of WP components that supports ToolbarItem
3815f85 
We need a fresh version of the package for our tests to run, especially for the Whatsapp block tests that include loading ToolbarItem.
@jeherve
Revert "Update to a version of WP components that supports ToolbarItem"
e9088c8 
This reverts commit 3815f85.
@jeherve
Revert ToolbarItem changes for the Whatsapp block
f0d2761 
Since that block has a set of tests, the tests need to be able to use ToolbarItem. If I update the version of @wordpress/components so it includes ToolbarItem, the tests pass, but the overall block build fails:

    ERROR in ./node_modules/@wp-g2/create-styles/node_modules/postcss/lib/map-generator.js
    Module not found: Error: Can't resolve 'path' in '.../jetpack/node_modules/@wp-g2/create-styles/node_modules/postcss/lib'

Let's consequently hold off this change until @wordpress/components is properly updated in a separate PR: #16763.
@jeherve
Add comment regarding ToolbarItem update issues
b91bb2a
@jeherve
Copy link
Member Author

jeherve commented Feb 22, 2021

JS tests are failing again.

I attempted to fix this (see 4 commits above). Unfortunately it will require a larger set of changes that I don't think are appropriate at this point of the release cycle (update the @wordpress/components package so the tests can pass). This should happen in #16763. Until then, I've reverted my change and I think we can live with the deprecation notice in the block editor in this case.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Has Changelog and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 22, 2021
jeherve added a commit that referenced this pull request Feb 23, 2021
@jeherve
Changelog: add #18860
080d2c7
mmtr
mmtr reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor, @jeherve! Reviewed the whole code and tested all affected blocks without noting any regression, except for the Anchor extension which should be easy to fix.

projects/plugins/jetpack/extensions/blocks/anchor-fm/anchor-fm.php Outdated Show resolved Hide resolved
mmtr
mmtr approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jeherve jeherve merged commit 41fe374 into master Feb 23, 2021
@jeherve jeherve deleted the update/wp-requirements-wp57 branch February 23, 2021 11:24
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 23, 2021
@jeherve
Copy link
Member Author

jeherve commented Feb 25, 2021

r221664-wpcom

@jeherve jeherve mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtr mmtr mmtr approved these changes

@anomiex anomiex anomiex left review comments

Assignees

@jeherve jeherve

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Block] Anchor Fm Anchor.fm integration [Block] Business Hours [Block] Calendly [Block] Contact Form Form block (also see Contact Form label) [Block] Dialogue [Block] Eventbrite [Block] Gathering Tweetstorms [Block] Map [Block] Paid Content aka Premium Content [Block] Pay With Paypal aka Simple Payments [Block] Payment Button aka Recurring Payments [Block] Pinterest [Block] Podcast Player [Block] Send a message [Block] Slideshow [Block] Story [Block] Tiled Gallery [Block] VideoPress [Feature] Shortcodes / Embeds [Feature] Widget Visibility General [Package] Lazy Images This package no longer exists in the monorepo. [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Touches WP.com Files Unit Tests
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @matticbot @anomiex @mmtr