Use type_is_in filter from the client to filter by multiple transaction types.
#9871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filter is already available on server.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +88 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
…ttic/woocommerce-payments into fix/use-type-is-in-filter
nagpai
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Code changes look great to me! The changes overcome the bug of the earlier makeshift search term-based filtering with more specific type filters, which is awesome. A small nitpick on the changelog text.
I did a round of manual test too and it looks good to ship.
As earlier, we can use WCCOM to test with a large amount of data.
Jinksi
reviewed
Dec 5, 2024
This seems important – we shouldn't have "hidden" state, modes or filters – it will confuse merchants and probably bite us later. Do we need to step back and consider the experience for merchants (i.e. design/UX)? |
|
Ideally it would show the filters in use.
|
6 tasks
Co-authored-by: Nagesh Pai <[email protected]>
|
Merging this because it would correct the mismatch. Better UX for filters will be tackled in another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8783
Changes proposed in this Pull Request
Testing instructions
View Reportlinks arehttps://....&path=%2Fpayments%2Ftransactions&filter=advanced&...type_is_in%5B0%5D=dispute&type_is_in%5B1%5D=dispute_reversal,typein search fieldnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge