Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button at Payments > Payouts is misaligned #9736

Closed
csmcneill opened this issue Nov 15, 2024 · 2 comments · Fixed by #9881
Closed

Download button at Payments > Payouts is misaligned #9736

csmcneill opened this issue Nov 15, 2024 · 2 comments · Fixed by #9881
Assignees
Labels
focus: reporting priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@csmcneill
Copy link
Contributor

Describe the bug

The Download button for various reports has typically been right-aligned (next to the ellipsis menu). However, on the Payments > Payouts page, it is misaligned.

Initial investigation suggests the alignment issue is caused by some justify-content: space-between; styling for the .woocommerce-report-table .components-card__header .woocommerce-table__actions element, but this styling is not present on other pages.

To Reproduce

  1. Log into wp-admin for a site with WooPayments that has processed payouts.
  2. Navigate to Payments > Transactions.
  3. Note the position of the gridicons-cloud-download SVG.
  4. Navigate to Payments > Payouts.
  5. Note the position of the gridicons-cloud-download SVG is left-aligned.

Actual behavior

The experience of downloading a report of an account's payout history is dissimilar from downloading other similar reports (e.g., transactions, disputes). We should try to make this experience as consistent as possible.

Screenshots

Image

Image

Expected behavior

The experience of locating and downloading reports should be consistent across the entire product.

Additional context

No user reports AFAIK. Found this issue while performing other tests.

@csmcneill csmcneill added the type: bug The issue is a confirmed bug. label Nov 15, 2024
@haszari haszari added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. and removed focus: payouts focus: payments acceptance & processing labels Dec 5, 2024
@haszari
Copy link
Contributor

haszari commented Dec 5, 2024

The Download button for various reports has typically been right-aligned (next to the ellipsis menu). However, on the Payments > Payouts page, it is misaligned.

Super weird that this is only on payouts view! Small thing but important to fix because it's inconsistent. Could potentially be a signal of deeper problem, these list views should ideally be 100% consistent.

@haszari haszari added priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Dec 5, 2024
@Jinksi Jinksi self-assigned this Dec 5, 2024
@Jinksi
Copy link
Member

Jinksi commented Dec 5, 2024

The cause, as spotted by @csmcneill, was introduced in #8996 as a temporary CSS fix when many search terms were active on the Transactions table after clicking through from a Payment Activity Card report (unreleased).

justify-content: space-between;

This inadvertently impacted the Payouts list styles.

Since we're removing the need for these styles in #9871, I'll open a new PR that removes them, resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: reporting priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
4 participants