Revert bumping minimum required version of WC 8.0.0 and WP 6.1 #7142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oCommerce and WP.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
shendy-a8c
commented
Sep 6, 2023
| Requires at least: 6.1 | ||
| Tested up to: 6.3 | ||
| Requires at least: 6.0 | ||
| Tested up to: 6.2 |
There was a problem hiding this comment.
I'm tempted to leave this as 6.3 (because we must have been testing up to that version) but goal of this PR is to revert #7050, so I went ahead to revert this line as well.
There was a problem hiding this comment.
You made the right call; we'll bump it again after we find the root cause.
shendy-a8c
commented
Sep 6, 2023
| * WC tested up to: 8.0.0 | ||
| * Requires at least: 6.1 | ||
| * WC requires at least: 7.6 | ||
| * WC tested up to: 7.8.0 |
There was a problem hiding this comment.
I'm tempted to leave this as 8.0.0 (because we must have been testing up to that version) but goal of this PR is to revert #7050, so I went ahead to revert this line as well.
There was a problem hiding this comment.
We can do it later, when we decide to bump it again.
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
| Significance: minor | ||
| Type: dev | ||
|
|
||
| Revert bumping minimum required version of WooCommerce to 7.8.0 and WP to 6.0 |
There was a problem hiding this comment.
I think it can be
Suggested change
| Revert bumping minimum required version of WooCommerce to 7.8.0 and WP to 6.0 | |
| Revert - Bump minimum required version of WooCommerce to 8.0.0 and WP to 6.1 | |
| Setting the minimum required version of WooCommerce back to 7.8.0 and WP to 6.0 |
There was a problem hiding this comment.
Nice. I wasn't sure about this too. I'll create a separate changelog entries because if I remember correctly, new lines in one changelog file will cause a problem when generating the final changelog.
There was a problem hiding this comment.
Addressed in 70af0ee.
| Requires at least: 6.1 | ||
| Tested up to: 6.3 | ||
| Requires at least: 6.0 | ||
| Tested up to: 6.2 |
There was a problem hiding this comment.
You made the right call; we'll bump it again after we find the root cause.
| * WC tested up to: 8.0.0 | ||
| * Requires at least: 6.1 | ||
| * WC requires at least: 7.6 | ||
| * WC tested up to: 7.8.0 |
There was a problem hiding this comment.
We can do it later, when we decide to bump it again.
…e are reverting and clearly stating the minimum required WC and WP version now.
|
If all looks good, I'll merge. |
shendy-a8c
deleted the
hotfix/revert-460-wp-wc-min-supported-version-bump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR is to revert WC and WP minimum required version bump done in 25a87d1 because it is causing problem.
More context can be found in: p1693997746543009-slack-C05RC4FKUAV
Testing instructions
I'm not sure how to test this other than making sure GH checks are green and plugin passes smoke testing.
The fixes to the found errors have been included in #7127, which is the base branch of this PR, so can't verify that the changes from this PR fixes those errors.
Also, make sure the changes from this PR reverts changes from #7050 except the changelog entry.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge