Bump WC and PHP versions #7134

ricardo · 2023-09-05T14:40:20Z

The changes and this PR were made via the wcpay:bump-versions command.

Bump WC 'tested up to' version to 7.9 and minimum version to 7.7.
Bump PHP version to 7.4 as per WC 8.1.

…p PHP minimum version to 7.4.

botwoo · 2023-09-05T14:46:29Z

Test the build

Option 1. Jetpack Beta

Install and activate Jetpack Beta.
Use this build by searching for PR number 7134 or branch name dev/bump-min-wc-8-1-php-7-4 in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

Latest commit: 4b6ec58
Build time: 2023-09-13 21:35:27 UTC

Note: the build is updated when a new commit is pushed to this PR.

github-actions · 2023-09-05T14:51:32Z

Size Change: 0 B

Total Size: 1.41 MB

ℹ️ View Unchanged

Filename	Size
`release/woocommerce-payments/assets/css/admin.css`	1.03 kB
`release/woocommerce-payments/assets/css/success.css`	158 B
`release/woocommerce-payments/dist/blocks-checkout-rtl.css`	1.51 kB
`release/woocommerce-payments/dist/blocks-checkout.css`	1.51 kB
`release/woocommerce-payments/dist/blocks-checkout.js`	73.6 kB
`release/woocommerce-payments/dist/checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/checkout.css`	441 B
`release/woocommerce-payments/dist/checkout.js`	28.6 kB
`release/woocommerce-payments/dist/index-rtl.css`	36 kB
`release/woocommerce-payments/dist/index.css`	36 kB
`release/woocommerce-payments/dist/index.js`	278 kB
`release/woocommerce-payments/dist/multi-currency-analytics.js`	1.05 kB
`release/woocommerce-payments/dist/multi-currency-rtl.css`	2.87 kB
`release/woocommerce-payments/dist/multi-currency-switcher-block.js`	59.8 kB
`release/woocommerce-payments/dist/multi-currency.css`	2.87 kB
`release/woocommerce-payments/dist/multi-currency.js`	54.4 kB
`release/woocommerce-payments/dist/order-rtl.css`	675 B
`release/woocommerce-payments/dist/order.css`	676 B
`release/woocommerce-payments/dist/order.js`	40.5 kB
`release/woocommerce-payments/dist/payment-gateways-rtl.css`	686 B
`release/woocommerce-payments/dist/payment-gateways.css`	688 B
`release/woocommerce-payments/dist/payment-gateways.js`	38 kB
`release/woocommerce-payments/dist/payment-request-rtl.css`	146 B
`release/woocommerce-payments/dist/payment-request.css`	146 B
`release/woocommerce-payments/dist/payment-request.js`	11.6 kB
`release/woocommerce-payments/dist/product-details.js`	789 B
`release/woocommerce-payments/dist/settings-rtl.css`	8.93 kB
`release/woocommerce-payments/dist/settings.css`	8.93 kB
`release/woocommerce-payments/dist/settings.js`	233 kB
`release/woocommerce-payments/dist/subscription-edit-page.js`	669 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.js`	20.2 kB
`release/woocommerce-payments/dist/subscription-product-onboarding-toast.js`	693 B
`release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.js`	19.3 kB
`release/woocommerce-payments/dist/tos-rtl.css`	230 B
`release/woocommerce-payments/dist/tos.css`	231 B
`release/woocommerce-payments/dist/tos.js`	21.8 kB
`release/woocommerce-payments/dist/upe_checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/upe_checkout.css`	441 B
`release/woocommerce-payments/dist/upe_checkout.js`	34 kB
`release/woocommerce-payments/dist/upe_split_checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/upe_split_checkout.css`	441 B
`release/woocommerce-payments/dist/upe_split_checkout.js`	34.6 kB
`release/woocommerce-payments/dist/upe_with_deferred_intent_creation_checkout.js`	36.5 kB
`release/woocommerce-payments/dist/upe-blocks-checkout-rtl.css`	1.51 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.css`	1.51 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.js`	39.5 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout-rtl.css`	1.51 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.css`	1.51 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.js`	41 kB
`release/woocommerce-payments/dist/woopay-express-button-rtl.css`	146 B
`release/woocommerce-payments/dist/woopay-express-button.css`	146 B
`release/woocommerce-payments/dist/woopay-express-button.js`	50.6 kB
`release/woocommerce-payments/dist/woopay-rtl.css`	3.85 kB
`release/woocommerce-payments/dist/woopay.css`	3.85 kB
`release/woocommerce-payments/dist/woopay.js`	71.6 kB
`release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css`	633 B
`release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js`	720 B
`release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js`	2.43 kB
`release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js`	1.01 kB
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js`	522 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js`	581 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js`	160 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css`	2.32 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js`	13.8 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css`	2.32 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css`	1.2 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css`	291 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css`	403 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css`	3.56 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css`	299 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css`	742 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css`	572 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css`	411 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js`	9.63 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js`	6.8 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js`	3.83 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js`	2.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js`	22.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js`	11.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js`	1.29 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js`	502 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js`	355 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js`	429 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js`	1.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js`	781 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js`	1.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js`	1.27 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css`	392 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js`	3.06 kB

_{compressed-size-action}

…oocommerce-payments into dev/bump-min-wc-8-1-php-7-4

ricardo · 2023-09-05T15:34:20Z

@Automattic/harmony WooCommerce 8.1 will require PHP 7.4 (src) so I ran wcpay:bump-versions with --php_min_version="7.4", however, in the past it seems like we didn't catch up with WC consistently and we've updated PHP based on our own dependencies requirements. What's the best approach here?

The wcpay:bump-versions works great, but had to tweak a few things manually:

Changed the composer.json PHP requirement to 7.4 as in WC (src).
Changed the PHP version matrix here to remove PHP 7.3 and add 2 newer versions.

cc @cesarcosta99

cesarcosta99 · 2023-09-11T22:26:54Z

@Automattic/harmony, any input on the approach taken here? See comment above.

I reintroduced the environment variable GUTENBERG_VERSION_FOR_WP_MIN in .github/workflows/compatibility.yml. That was being used when this PR was opened. It got removed in #7142 as part of a revert and its absence was causing the Compatibility - WC, WP and PHP / WC compatibility (7.9.0, 6.1, 15.7.0, 7.4) check to fail (using version 13.6.0). @shendy-a8c, since you've opened that revert PR, any objections or concerns with this, or any change, in this PR? I see the revert was meant to resolve part of an incident so your insight is much appreciated here.

jbordonado · 2023-09-12T08:43:40Z

I think we should not bump our dependency requirements until #7147 is done, given that doing it recently triggered a patch release 6.4.1, as you rightly noticed

Also, we're bumping the minimum WC version by 3, which could be too much for merchants.. Maybe let's increment by one at each release until we caught up again with the latest?

shendy-a8c · 2023-09-12T12:44:03Z

@shendy-a8c, since you've opened that revert PR, any objections or concerns with this, or any change, in this PR? I see the revert was meant to resolve part of an incident so your insight is much appreciated here.

No concern around GUTENBERG_VERSION_FOR_WP_MIN environment variable introduction.

#7142 was solely a revert PR to move forward with our recent 6.4.1 patch release.

rafaelzaleski

LGTM 👍
Should PHP testing (7.3) be removed from the list of required checks for trunk merging?

cesarcosta99 · 2023-09-13T21:28:08Z

Should PHP testing (7.3) be removed from the list of required checks for trunk merging?

@rafaelzaleski, I think that check is in the limbo because we removed 7.3. Looks like in other PRs we don't see it that way, and in fact, the 7.3 one is duplicated – that is being fixed in this PR, though, and as soon this PR is merged we'll have 7.4, 8.0 and 8.1 being tested.

cesarcosta99 · 2023-09-13T21:46:55Z

Also, we're bumping the minimum WC version by 3, which could be too much for merchants.. Maybe let's increment by one at each release until we caught up again with the latest?

@eduardoumpierre, just FYI, I only bumped 1 minimum WC version, which means we need to bump it again in the following two releases, at least.

jbordonado · 2023-09-14T07:39:50Z

Was there any progress on the incident fix? I thought we agreed to wait for a proper fix before bumping again, but maybe I missed something

cesarcosta99 · 2023-09-14T14:48:59Z

@jbordonado if we should've waited, that was unclear. The only call out so far was to not bump the dependency requirements, which I reverted.

This reverts commit a23c791.

Co-authored-by: César Costa <[email protected]>

Bump WC 'tested up to' version to 8.1 and minimum version to 7.9. Bum…

19f314b

…p PHP minimum version to 7.4.

ricardo requested a review from a team as a code owner September 5, 2023 14:40

ricardo added 4 commits September 5, 2023 11:53

Add changelog entry

67d9c8c

Merge branch 'dev/bump-min-wc-8-1-php-7-4' of github.com:Automattic/w…

1f1d512

…oocommerce-payments into dev/bump-min-wc-8-1-php-7-4

Bump composer PHP version

5026167

Remove 7.3 tests and add 8.0 and 8.1 to the version matrix

72dc9d2

cesarcosta99 and others added 4 commits September 8, 2023 18:34

Merge branch 'develop' into dev/bump-min-wc-8-1-php-7-4

a6a7c66

Merge branch 'develop' into dev/bump-min-wc-8-1-php-7-4

514900a

Revert env var removal

0278e07

Ensure proper version of Gutenberg

bc6a2e4

cesarcosta99 and others added 4 commits September 13, 2023 16:20

Bump WC 'tested up to' version to 7.9 and minimum version to 7.7

3fe4fa2

Update changelog

be946e5

Revert composer.lock changes

fc22455

Merge branch 'develop' into dev/bump-min-wc-8-1-php-7-4

4ad0df9

cesarcosta99 requested review from a team, cesarcosta99 and rafaelzaleski and removed request for a team and cesarcosta99 September 13, 2023 19:47

rafaelzaleski approved these changes Sep 13, 2023

View reviewed changes

cesarcosta99 enabled auto-merge September 13, 2023 21:31

Merge branch 'develop' into dev/bump-min-wc-8-1-php-7-4

4b6ec58

cesarcosta99 disabled auto-merge September 13, 2023 21:32

cesarcosta99 merged commit a23c791 into develop Sep 13, 2023
27 checks passed

cesarcosta99 deleted the dev/bump-min-wc-8-1-php-7-4 branch September 13, 2023 21:46

cesarcosta99 added a commit that referenced this pull request Sep 14, 2023

Revert "Bump WC and PHP versions (#7134)"

f1c0297

This reverts commit a23c791.

ricardo mentioned this pull request Sep 14, 2023

Revert "Bump WC and PHP versions (#7134)" #7213

Merged

6 tasks

Jinksi mentioned this pull request Sep 15, 2023

Transaction Details → fix typo in staged dispute challenge notice #7217

Merged

6 tasks

ricardo added a commit that referenced this pull request Sep 15, 2023

Revert "Bump WC and PHP versions (#7134)" (#7213)

c4a7445

Co-authored-by: César Costa <[email protected]>

vladolaru mentioned this pull request Sep 16, 2024

Improve our job scheduling service for more resilience #9435

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump WC and PHP versions #7134

Bump WC and PHP versions #7134

ricardo commented Sep 5, 2023 •

edited by cesarcosta99

Loading

botwoo commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

ricardo commented Sep 5, 2023

cesarcosta99 commented Sep 11, 2023

jbordonado commented Sep 12, 2023

shendy-a8c commented Sep 12, 2023

rafaelzaleski left a comment

cesarcosta99 commented Sep 13, 2023

cesarcosta99 commented Sep 13, 2023

jbordonado commented Sep 14, 2023

cesarcosta99 commented Sep 14, 2023

Bump WC and PHP versions #7134

Bump WC and PHP versions #7134

Conversation

ricardo commented Sep 5, 2023 • edited by cesarcosta99 Loading

botwoo commented Sep 5, 2023 • edited Loading

Test the build

Option 1. Jetpack Beta

Option 2. Jurassic Ninja - available for logged-in A12s

github-actions bot commented Sep 5, 2023 • edited Loading

ricardo commented Sep 5, 2023

cesarcosta99 commented Sep 11, 2023

jbordonado commented Sep 12, 2023

shendy-a8c commented Sep 12, 2023

rafaelzaleski left a comment

Choose a reason for hiding this comment

cesarcosta99 commented Sep 13, 2023

cesarcosta99 commented Sep 13, 2023

jbordonado commented Sep 14, 2023

cesarcosta99 commented Sep 14, 2023

ricardo commented Sep 5, 2023 •

edited by cesarcosta99

Loading

botwoo commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading