Fix changing Stripe Billing payment method which wasn't cancelling at Stripe #7195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on meta if they are still wcpay subscriptions
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
james-allan
changed the title
14 tasks
mattallan
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
LGTM. Here are the test cases I went through:
- Update a Stripe Billing subscription's payment method to another WooPayments card. Confirm subscription remains active in Stripe with new payment method
- Update a Stripe Billing subscription's payment method to Square. Confirm subscription at Stripe is canceled and meta
_cancelled_wcpay_subscription_idis set - Change a legacy WCPay subscription method (can only change between woopayments)
- Update a regular subscription payment method from WooPayments to Square
james-allan
deleted the
fix/changing-stripe-billing-payment-method-doesnt-cancel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR fixes 2 issues:
Testing instructions
4000056655665556.develop)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge