Adds environment metadata to Stripe Billing subscription and invoice payment intents #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
mattallan
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
- With Woo Subscriptions inactive
- With Woo Subscriptions active
- Subscription Renewals with Woo Subscriptions active and inactive
- Confirmed subscription_context is "stripe_billing" when plugin active
- Confirmed "legacy_wcpay_subscription" when deactivated
- With Woo Subscriptions and Stripe Billing disabled, confirmed "regular_subscription" payment context on parent and renewal order charges
Code changes look good and tests all went well alongside the changes on server. Happy to approve this!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6529
Changes proposed in this Pull Request
This PR adds 2 pieces of meta data to Stripe Billing objects:
Subscription metadata
Rationale
When a store has the Woo Subscriptions plugin active and a Stripe Billing subscription is created they must have had Stripe Billing enabled at the time. If the plugin isn't active and they are still creating Stripe Billing subscriptions. Then they are still using WCPay Subscriptions. This meta data can be used to identify how many merchants are actively using Stripe Billing subscriptions, or still using WCPay Subscriptions.
Payment intent metadata
Rationale
When we receive a webhook for a Stripe Billing renewal order (paid of failed), we want to know under what context this payment is being processed. Have they actively opted into Stripe Billing, are still using WCPay subscriptions, or have installed Woo Subscriptions but haven't migrated their subscriptions.
Testing instructions
add/support_for_subscription_and_invoice_metaserver branch for these changes to work correctly.Subscriptions
With Woo Subscriptions inactive
wcpay_subscriptionsmeta.With Woo Subscriptions active
woo_subscriptionmeta.Subscription Renewals
Subscription updateddescription.subscription_contextstripe_billing) is added.Subscription updateddescription.subscription_contextlegacy_wcpay_subscription) is added.Subscription updateddescription.subscription_contextlegacy_wcpay_subscription) is added.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge