Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bumping minimum required version of WC 8.0.0 and WP 6.1 #7142

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Revert bumping minimum required version of WC 8.0.0 and WP 6.1 #7142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c437ca1
Revert commit 25a87d1faf16d11e0c40d9ac48f3f47263efc469 that was bumpi…
shendy-a8c Sep 6, 2023
70af0ee
Make changelog entries more clear by preserving the changelog entry w…
shendy-a8c Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ on:
pull_request

env:
WC_MIN_SUPPORTED_VERSION: '7.8.0'
WP_MIN_SUPPORTED_VERSION: '6.1'
WC_MIN_SUPPORTED_VERSION: '7.6.0'
WP_MIN_SUPPORTED_VERSION: '6.0'
PHP_MIN_SUPPORTED_VERSION: '7.3'
GUTENBERG_VERSION_FOR_WP_MIN: '15.7.0'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -24,7 +23,7 @@ jobs:
id: generate_matrix
run: |
WC_VERSIONS=$( echo "[\"$WC_MIN_SUPPORTED_VERSION\", \"latest\", \"beta\"]" )
MATRIX_INCLUDE=$( echo "[{\"woocommerce\":\"$WC_MIN_SUPPORTED_VERSION\",\"wordpress\":\"$WP_MIN_SUPPORTED_VERSION\",\"gutenberg\":\"$GUTENBERG_VERSION_FOR_WP_MIN\",\"php\":\"$PHP_MIN_SUPPORTED_VERSION\"}]" )
MATRIX_INCLUDE=$( echo "[{\"woocommerce\":\"$WC_MIN_SUPPORTED_VERSION\",\"wordpress\":\"$WP_MIN_SUPPORTED_VERSION\",\"gutenberg\":\"13.6.0\",\"php\":\"$PHP_MIN_SUPPORTED_VERSION\"}]" )
echo "matrix={\"woocommerce\":$WC_VERSIONS,\"wordpress\":[\"latest\"],\"gutenberg\":[\"latest\"],\"php\":[\"7.4\"], \"include\":$MATRIX_INCLUDE}" >> $GITHUB_OUTPUT

woocommerce-compatibility:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:
E2E_SLACK_TOKEN: ${{ secrets.E2E_SLACK_TOKEN }}
E2E_USE_LOCAL_SERVER: false
E2E_RESULT_FILEPATH: 'tests/e2e/results.json'
WC_MIN_SUPPORTED_VERSION: '7.8.0'
WC_MIN_SUPPORTED_VERSION: '7.6.0'
NODE_ENV: 'test'
FORCE_E2E_DEPS_SETUP: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

env:
WP_VERSION: latest
WC_MIN_SUPPORTED_VERSION: '7.8.0'
WC_MIN_SUPPORTED_VERSION: '7.6.0'
GUTENBERG_VERSION: latest
PHP_MIN_SUPPORTED_VERSION: '7.3'

Expand Down
4 changes: 4 additions & 0 deletions changelog/hotfix-revert-460-wp-wc-min-supported-version-bump
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: dev

Revert bumping minimum required version of WooCommerce to 7.8.0 and WP to 6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be

Suggested change
Revert bumping minimum required version of WooCommerce to 7.8.0 and WP to 6.0
Revert - Bump minimum required version of WooCommerce to 8.0.0 and WP to 6.1
Setting the minimum required version of WooCommerce back to 7.8.0 and WP to 6.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wasn't sure about this too. I'll create a separate changelog entries because if I remember correctly, new lines in one changelog file will cause a problem when generating the final changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 70af0ee.

2 changes: 1 addition & 1 deletion phpcs-compat.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<exclude-pattern>tests/</exclude-pattern>

<!-- Configs -->
<config name="minimum_supported_wp_version" value="6.1" />
<config name="minimum_supported_wp_version" value="6.0" />
<config name="testVersion" value="7.3-" />

<rule ref="PHPCompatibility">
Expand Down
2 changes: 1 addition & 1 deletion phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<exclude-pattern>./lib/*</exclude-pattern>

<!-- Configs -->
<config name="minimum_supported_wp_version" value="6.1" />
<config name="minimum_supported_wp_version" value="6.0" />
<config name="testVersion" value="7.3-" />

<!-- Rules -->
Expand Down
8 changes: 4 additions & 4 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
=== WooPayments - Fully Integrated Solution Built and Supported by Woo ===
Contributors: woocommerce, automattic
Tags: payment gateway, payment, apple pay, credit card, google pay, woocommerce payments
Requires at least: 6.1
Tested up to: 6.3
Requires at least: 6.0
Tested up to: 6.2
Copy link
Contributor Author

@shendy-a8c shendy-a8c Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to leave this as 6.3 (because we must have been testing up to that version) but goal of this PR is to revert #7050, so I went ahead to revert this line as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made the right call; we'll bump it again after we find the root cause.

Requires PHP: 7.3
Stable tag: 6.4.1
License: GPLv2 or later
Expand Down Expand Up @@ -38,8 +38,8 @@ Our global support team is available to answer questions you may have about WooP

= Requirements =

* WordPress 6.1 or newer.
* WooCommerce 7.8 or newer.
* WordPress 6.0 or newer.
* WooCommerce 7.6 or newer.
* PHP 7.3 or newer is recommended.

= Try it now =
Expand Down
6 changes: 3 additions & 3 deletions woocommerce-payments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
* Woo: 5278104:bf3cf30871604e15eec560c962593c1f
* Text Domain: woocommerce-payments
* Domain Path: /languages
* WC requires at least: 7.8
* WC tested up to: 8.0.0
* Requires at least: 6.1
* WC requires at least: 7.6
* WC tested up to: 7.8.0
Copy link
Contributor Author

@shendy-a8c shendy-a8c Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to leave this as 8.0.0 (because we must have been testing up to that version) but goal of this PR is to revert #7050, so I went ahead to revert this line as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it later, when we decide to bump it again.

* Requires at least: 6.0
* Requires PHP: 7.3
* Version: 6.4.1
*
Expand Down