Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle edited messages (update_message events, 1/2) #118

Closed
gnprice opened this issue May 26, 2023 · 4 comments · Fixed by #238
Closed

Handle edited messages (update_message events, 1/2) #118

gnprice opened this issue May 26, 2023 · 4 comments · Fixed by #238
Assignees
Labels
a-api Implementing specific parts of the Zulip server API
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented May 26, 2023

https://zulip.com/api/get-events#update_message

This issue is for the case where the message's contents were changed. (The case where the message changed stream and/or topic is #150.)

In particular these should be handled in the MessageListView view-model, so that the edits get reflected in a message list the user might be looking at.

For this issue, we'll:

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 26, 2023

@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label May 26, 2023
@gnprice gnprice added this to the Alpha milestone May 27, 2023
@gnprice gnprice removed the m-alpha label May 27, 2023
@gnprice gnprice changed the title Handle edited messages (update_message events) Handle edited messages (update_message events, 1/2) Jun 2, 2023
@gnprice
Copy link
Member Author

gnprice commented Jul 6, 2023

Add a new Event subclass for these events, similar to the others.

This part is now done, as #212.

The remaining part of this issue is to handle the events.

@oxling
Copy link
Contributor

oxling commented Jul 21, 2023

👋 Hello! I'll take on the event handling.

@gnprice
Copy link
Member Author

gnprice commented Jul 21, 2023

Sounds great! Marked on the issue metadata that you're taking it on.

oxling pushed a commit to oxling/zulip-flutter that referenced this issue Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling pushed a commit to oxling/zulip-flutter that referenced this issue Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 28, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling added a commit to oxling/zulip-flutter that referenced this issue Jul 28, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
@gnprice gnprice closed this as completed in cff73ee Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants