-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle edited messages (update_message events, 1/2) #118
Comments
Related issue: |
72 tasks
gnprice
changed the title
Handle edited messages (update_message events)
Handle edited messages (update_message events, 1/2)
Jun 2, 2023
This part is now done, as #212. The remaining part of this issue is to handle the events. |
👋 Hello! I'll take on the event handling. |
Sounds great! Marked on the issue metadata that you're taking it on. |
oxling
pushed a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
pushed a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 24, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 25, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 26, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 28, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
oxling
added a commit
to oxling/zulip-flutter
that referenced
this issue
Jul 28, 2023
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://zulip.com/api/get-events#update_message
This issue is for the case where the message's contents were changed. (The case where the message changed stream and/or topic is #150.)
In particular these should be handled in the MessageListView view-model, so that the edits get reflected in a message list the user might be looking at.
For this issue, we'll:
Event
subclass for these events, similar to the others.new_stream_id
,propagate_mode
, and all the other properties that are documented at https://zulip.com/api/get-events#update_message as present only when the event moved messages. (We'll get to those later as part of Handle moved messages (update_message events, 2/2) #150.)PerAccountStore.handleEvent
by calling a newly-added method onMessageListView
, similar to the handling ofMessageEvent
.The text was updated successfully, but these errors were encountered: