forked from zulip/zulip-flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
msglist: Handle updated events in MessageListView (zulip#118).
Processes an UpdateMessageEvent and hands it off to the MessageListView to update, if the message is visible in the MessageListView. This completes the changes required for issue zulip#118.
- Loading branch information
Showing
4 changed files
with
173 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
import 'package:checks/checks.dart'; | ||
import 'package:test/scaffolding.dart'; | ||
import 'package:zulip/api/model/events.dart'; | ||
import 'package:zulip/api/model/model.dart'; | ||
import 'package:zulip/api/route/messages.dart'; | ||
import 'package:zulip/model/message_list.dart'; | ||
import 'package:zulip/model/narrow.dart'; | ||
import 'package:zulip/model/store.dart'; | ||
import '../api/fake_api.dart'; | ||
import '../model/binding.dart'; | ||
import '../model/test_store.dart'; | ||
import '../example_data.dart' as eg; | ||
|
||
const int userId = 1; | ||
const int streamId = 2; | ||
|
||
Future<PerAccountStore> setupStore(ZulipStream stream) async { | ||
await TestZulipBinding.instance.globalStore.add(eg.selfAccount, eg.initialSnapshot()); | ||
PerAccountStore store = await TestZulipBinding.instance.globalStore.perAccount(eg.selfAccount.id); | ||
store.addUser(eg.user(userId: userId)); | ||
store.addStream(stream); | ||
return store; | ||
} | ||
|
||
void main() async { | ||
TestZulipBinding.ensureInitialized(); | ||
const narrow = StreamNarrow(streamId); | ||
|
||
final ZulipStream stream = eg.stream(streamId: streamId); | ||
PerAccountStore store = await setupStore(stream); | ||
|
||
group('update message tests', () { | ||
|
||
test('find message in message list returns index of message', () async { | ||
MessageListView messageList = MessageListView.init(store: store, narrow: narrow); | ||
|
||
final connection = store.connection as FakeApiConnection; | ||
Message m1 = eg.streamMessage(id: 792, stream: stream); | ||
Message m2 = eg.streamMessage(id: 793, stream: stream); | ||
Message m3 = eg.streamMessage(id: 794, stream: stream); | ||
|
||
connection.prepare(json: GetMessagesResult( | ||
anchor: m1.id, | ||
foundNewest: true, | ||
foundOldest: true, | ||
foundAnchor: true, | ||
historyLimited: false, | ||
messages: [m1, m2, m3], | ||
).toJson()); | ||
|
||
await messageList.fetch(); | ||
|
||
check(messageList.messages.length).equals(3); | ||
|
||
int idx = messageList.findMessageWithId(793); | ||
check(idx).equals(1); | ||
|
||
idx = messageList.findMessageWithId(999); | ||
check(idx).equals(-1); | ||
}); | ||
|
||
test('update events are correctly applied to message', () async { | ||
MessageListView messageList = MessageListView.init(store: store, narrow: narrow); | ||
|
||
final connection = store.connection as FakeApiConnection; | ||
String oldContent = "<p>Hello, world</p>"; | ||
String newContent = "<p>Hello, edited</p>"; | ||
int newTimestamp = 99999; | ||
|
||
Message m = eg.streamMessage(id: 243, stream: stream, content: oldContent); | ||
connection.prepare(json: GetMessagesResult( | ||
anchor: m.id, | ||
foundNewest: true, | ||
foundOldest: true, | ||
foundAnchor: true, | ||
historyLimited: false, | ||
messages: [m], | ||
).toJson()); | ||
|
||
await messageList.fetch(); | ||
|
||
UpdateMessageEvent updateEvent = UpdateMessageEvent( | ||
id: 1, | ||
messageId: m.id, | ||
messageIds: [m.id], | ||
flags: m.flags, | ||
renderedContent: newContent, | ||
editTimestamp: newTimestamp | ||
); | ||
|
||
Message oldMessage = messageList.messages[0]; | ||
check(oldMessage.content).equals(oldContent); | ||
|
||
messageList.maybeUpdateMessage(updateEvent); | ||
|
||
Message updatedMessage = messageList.messages[0]; | ||
|
||
check(updatedMessage.content).equals(newContent); | ||
check(updatedMessage.lastEditTimestamp).equals(newTimestamp); | ||
|
||
}); | ||
}); | ||
} |