-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle deleted messages (delete_message events) #120
Labels
a-api
Implementing specific parts of the Zulip server API
Milestone
Comments
72 tasks
We now parse these events, since #212. The remaining task in this issue is to handle them in [PerAccountStore.handleEvent], by updating our data structures that are affected. |
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 26, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 28, 2024
When handling a message deletion event, we just simply remove the messages from the per account store and wipe them from the message list view if they are present. Because message deletion can affect what items are to be seen (date separator, recipient header, etc.), if the view has any message deleted, a `_reprocessAll` call is triggered. It would be ideal to just removed the affected items for better performance. Fixes zulip#120. Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://zulip.com/api/get-events#delete_message
Related issue:
The text was updated successfully, but these errors were encountered: