fix(v2): Toggle off Auto Save and warn user after save error

[traeok]

Proposed changes

Fixes #2406, #2627

Error message shown when Auto Save is enabled:

How to test

• Locate a UNIX file or data set with insufficient write permissions.
• Open this resource in Zowe Explorer.
• Enable Auto Save and make changes to the file
• Notice that when the save error occurs, the document is marked unsaved and no more save requests are made. Notice that Auto Save is also disabled.
  • Try enabling the Auto Save feature using either the "Enable Auto Save" option in this dialog, or by using the Command Palette -> "Files: Toggle Auto Save". The process will repeat at this point, but the save request will only happen once.

When Auto Save is used with v2.18.0, save requests were continuously added for each data set and file that failed to save. Even if you would try to close the file or dismiss the error, another request would be added, and a reload of VS Code was necessary to stop the loop.

Release Notes

Milestone: 2.18.1

Changelog:

• Fixed an issue when Auto Save is enabled where a failed UNIX file or data set save operation resulted in an indefinite loop of additional save requests. #2406, #2627

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[github-actions]

📅 Suggested merge-by date: 12/26/2024

[JillieBeanSim]

LGTM! thanks for this fix @traeok

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (d7f1903) to head (ace4aef).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files

@@            Coverage Diff             @@
##           v2-lts    #3359      +/-   ##
==========================================
+ Coverage   93.39%   93.41%   +0.01%     
==========================================
  Files         105      105              
  Lines       11133    11161      +28     
  Branches     2465     2348     -117     
==========================================
+ Hits        10398    10426      +28     
  Misses        734      734              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

I was a bit confused when I saw the localize function but then realized this was for V2 😋

LGTM! 🙏

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.7% Duplication on New Code

See analysis details on SonarQube Cloud

[zFernand0]

still LGTM! 😋
thanks for adding the extra test 🙏

[JillieBeanSim]

still LGTM! thanks @traeok