Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle VSCode auto-save functionality #2579

Closed
t1m0thyj opened this issue Nov 15, 2023 · 2 comments · Fixed by #3359
Closed

Handle VSCode auto-save functionality #2579

t1m0thyj opened this issue Nov 15, 2023 · 2 comments · Fixed by #3359
Assignees
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@t1m0thyj
Copy link
Member

If auto-save is enabled in VS Code ("File" -> "Auto Save"), the default behavior is to save every second. Unless users set a longer delay or pick a less aggressive option in the dropdown below, this results in Zowe Explorer continuously issuing new upload requests while a file is being edited (as often as every second if the connection is fast enough).

We would like to limit the number of requests that Zowe Explorer makes, so that we don't flood the mainframe with requests and are able to properly handle conflict management without race conditions. Some ideas for how we could handle this:

  • Add a warning to our documentation that certain values for the auto-save setting are not recommended for Zowe Explorer users. Perhaps also detect when ZE launches if the auto-save setting is set to save every second, and if so then show a warning that recommends configuring VS Code to auto-save less frequently.
  • In v3 if we use a FileSystemProvider (Use vscode.FileSystemProvider for content downloaded from mainframe #2207), we should have complete control over the file save and conflict handling operations. This would allow us to ignore save events triggered by auto-save and only handle manual saves, or introduce a new VS Code setting that limits the frequency of ZE upload requests.
@t1m0thyj t1m0thyj added enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Nov 15, 2023
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 10 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@t1m0thyj t1m0thyj moved this from New Issues to Low Priority in Zowe Explorer for VS Code Dec 26, 2023
@traeok
Copy link
Member

traeok commented Dec 18, 2024

Closed as completed in #3359 - Auto Save is supported in out-of-the-box in v3 w/ the FileSystemProvider

@traeok traeok closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Low Priority to Closed in Zowe Explorer for VS Code Dec 18, 2024
@traeok traeok self-assigned this Dec 18, 2024
@traeok traeok linked a pull request Dec 18, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants