Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds: Show error for unsaved dataset rename; use mtime in ms for DS entries #3326

Merged
merged 16 commits into from
Nov 22, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 18, 2024

Proposed changes

For USS, we show an error if you go to rename a file or parent folder with unsaved changes. I've added this logic to the data sets tree for consistency.

This also changes data set mtime updates from the mainframe be set in milliseconds. This might avoid accidental conflict detection by VS Code as described in #3310.

Release Notes

Milestone: 3.1.0

Changelog:

  • (API) Fixed issue where modification time updates to data set resources were saved in seconds rather than milliseconds since epoch.
  • (ZE) Fixed an issue where renaming a data set with unsaved changes did not cancel the rename operation. Now, when renaming a data set with unsaved changes, you will be prompted to resolve them before continuing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 18, 2024
@traeok traeok added this to the v3.1.0 milestone Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (66f4592) to head (a529d1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
+ Coverage   93.03%   93.07%   +0.04%     
==========================================
  Files         116      116              
  Lines       12094    12109      +15     
  Branches     2740     2744       +4     
==========================================
+ Hits        11252    11271      +19     
+ Misses        841      837       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@traeok traeok force-pushed the fix/warn-before-ds-rename branch from 91bd557 to 57cb760 Compare November 18, 2024 21:23
@traeok traeok changed the title fix(ds): Show error if renaming data set with unsaved changes fix(ds): Show error if renaming data set w/ unsaved changes; use mtime in ms for DS entries Nov 18, 2024
@traeok traeok changed the title fix(ds): Show error if renaming data set w/ unsaved changes; use mtime in ms for DS entries fix(ds): Error if renaming data set w/ unsaved changes; mtime in ms for DS entries Nov 18, 2024
@traeok traeok changed the title fix(ds): Error if renaming data set w/ unsaved changes; mtime in ms for DS entries ds: Show error for unsaved dataset rename; use mtime in ms for DS entries Nov 18, 2024
@traeok traeok marked this pull request as ready for review November 19, 2024 20:23
Copy link

📅 Suggested merge-by date: 12/3/2024

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion for the changelog

packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
@traeok traeok requested a review from anaxceron November 19, 2024 21:18
anaxceron
anaxceron previously approved these changes Nov 20, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changelog!

awharn
awharn previously approved these changes Nov 21, 2024
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

@t1m0thyj t1m0thyj merged commit 07232b7 into main Nov 22, 2024
32 checks passed
@t1m0thyj t1m0thyj deleted the fix/warn-before-ds-rename branch November 22, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants