fix(v2): Show error for unsaved data set rename

[traeok]

Proposed changes

v2 port of the error dialog from #3326

Release Notes

Milestone: 2.18.1

Changelog:

• Fixed an issue where renaming a data set with unsaved changes did not cancel the rename operation. Now, when renaming a data set with unsaved changes, you will be prompted to resolve them before continuing. #3328

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (a5a0cd7) to head (7705058).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files

@@            Coverage Diff             @@
##           v2-lts    #3328      +/-   ##
==========================================
+ Coverage   93.36%   93.38%   +0.02%     
==========================================
  Files         105      105              
  Lines       11092    11117      +25     
  Branches     2426     2356      -70     
==========================================
+ Hits        10356    10382      +26     
+ Misses        735      734       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[traeok]

Not sure why SonarCloud and the Pull Request Size bot is having a bad time. I think it might have been because I changed the base branch after opening the PR.

That said, disregard the SonarCloud message as its not accurate. I've marked the SonarCloud message as outdated.

[github-actions]

📅 Suggested merge-by date: 12/3/2024

[sonarqubecloud]

Quality Gate failed

Failed conditions
17.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[anaxceron]

Made some comments on the changelog and other items.

[anaxceron]

Is there an extra space between the period and the quotation marks in the first message? Not sure.

[traeok]

No extra spaces here - the text was simply split into two sections to avoid the "max length" limit that we have set for lines of code.

[t1m0thyj]

The + sign seems unnecessary here since the text isn't split across multiple lines:

Suggested change

	"Unable to rename testFile.txt because you have unsaved changes in this file. " + "Please save your work and try again.",
	"Unable to rename testFile.txt because you have unsaved changes in this file. Please save your work and try again.",

[anaxceron]

good stuff, @traeok, thank you!

[t1m0thyj]

This doesn't prevent me from renaming a member with unsaved changes. The V3 PR behaved as expected.

[t1m0thyj]

LGTM once I fixed my environment, thanks @traeok and sorry for the false alarm