-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue with overrides file not writing correctly #2537
Conversation
Signed-off-by: Rudy Flores <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
LGTM! 😋
Q: do we want to merge this before the release, or as a patch in the maintenance branch?
(I don't see a problem with just getting this in 2.12.0)
@t1m0thyj @zFernand0 here's the scenarios to test with this PR to make sure behavior is still the same #2492 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rudyflores!
Hey Rudy, |
Proposed changes
Turns out our issue with the breaking Theia test wasn't due to multiple calls to ProfilesInfo occuring on credential management load, the issue was a missing error handling for when reading the
imperative.json
file, since in Theia the file doesn't exist initially in our tests.Release Notes
Milestone: v2.12.0
Changelog: Fixed issue with
writeOverridesFile
function not writing properlyTypes of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments