Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with overrides file not writing correctly #2537

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Oct 30, 2023

Proposed changes

Turns out our issue with the breaking Theia test wasn't due to multiple calls to ProfilesInfo occuring on credential management load, the issue was a missing error handling for when reading the imperative.json file, since in Theia the file doesn't exist initially in our tests.

Release Notes

Milestone: v2.12.0

Changelog: Fixed issue with writeOverridesFile function not writing properly

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Rudy Flores <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/zowe-explorer/src/utils/ProfilesUtils.ts 92.10% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
LGTM! 😋

Q: do we want to merge this before the release, or as a patch in the maintenance branch?

(I don't see a problem with just getting this in 2.12.0)

@rudyflores rudyflores added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 31, 2023
@rudyflores rudyflores added this to the v2.12.0 milestone Oct 31, 2023
@rudyflores
Copy link
Contributor Author

@t1m0thyj @zFernand0 here's the scenarios to test with this PR to make sure behavior is still the same #2492

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rudyflores!

@JillieBeanSim JillieBeanSim merged commit 7ecb12e into main Nov 1, 2023
23 of 24 checks passed
@JillieBeanSim JillieBeanSim deleted the fix-overrides-file-writing2 branch November 1, 2023 12:30
@zFernand0
Copy link
Member

Hey Rudy,
I was able to see the pop-ups (from the other PR with the K8s-secrets). 😋
Sorry for not reporting this sooner😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants