Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with overrides file not writing correctly #2535

Closed
wants to merge 6 commits into from

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Oct 30, 2023

Proposed changes

Turns out our issue with the breaking Theia test wasn't due to multiple calls to ProfilesInfo occuring on credential management load, the issue was a missing error handling for when reading the imperative.json file, since in Theia the file doesn't exist initially in our tests.

Release Notes

Milestone: v2.12.0

Changelog: Fixed issue with writeOverridesFile function not writing properly

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

@rudyflores rudyflores self-assigned this Oct 30, 2023
@rudyflores rudyflores mentioned this pull request Oct 30, 2023
16 tasks
@rudyflores rudyflores added this to the v2.12.0 milestone Oct 30, 2023
Signed-off-by: Rudy Flores <[email protected]>
@rudyflores rudyflores added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/zowe-explorer/src/utils/ProfilesUtils.ts 92.10% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rudyflores rudyflores changed the base branch from 2.12.0-release to main October 30, 2023 22:05
@rudyflores
Copy link
Contributor Author

closing in favor of #2537

@rudyflores rudyflores closed this Oct 30, 2023
@rudyflores rudyflores deleted the fix-overrides-file-writing branch October 30, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants