Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match capy click selectors with underlying html #1856

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Match capy click selectors with underlying html #1856

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f19662e
Matches click selectors with html
rosschapman Sep 28, 2023
139e88a
Merge branch 'main' into match-click-selectors-with-html
rosschapman Oct 26, 2023
9b3f3b4
Fix other specs
rosschapman Oct 26, 2023
0f1ab2a
Oops found a couple more
rosschapman Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@ Style/TrailingCommaInArrayLiteral:
Rails/CreateTableWithTimestamps:
Exclude:
- db/schema.rb

Capybara/ClickLinkOrButtonStyle:
EnforcedStyle: link_or_button
2 changes: 1 addition & 1 deletion spec/support/system_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Spec
module SystemHelpers
def sign_in(user, space)
visit(polymorphic_path(space.location))
click_link_or_button("Sign in")
click_link("Sign in")
fill_in("authenticated_session[contact_location]", with: user.email)
find('input[type="submit"]').click
perform_enqueued_jobs
Expand Down
6 changes: 3 additions & 3 deletions spec/system/furniture_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
def add_gizmo(type, room:)
visit(polymorphic_path(room.location(:edit)))
select(type, from: "Type of gizmo")
click_link_or_button("Add Gizmo")
click_button("Add Gizmo")
end

def remove_gizmo(type, room:)
visit(polymorphic_path(room.location(:edit)))
expect(page).to have_text("Markdown Text Block")
within("##{dom_id(room.gizmos.first)}") do
click_link_or_button "Configure Markdown Text Block"
click_link "Configure Markdown Text Block"
end
click_link_or_button "Remove Gizmo"
click_link "Remove Gizmo"
end
end
Loading