Match capy click selectors with underlying html #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosschapman
force-pushed
the
match-click-selectors-with-html
branch
from
8631c39 to
f19662e
Compare
rosschapman
changed the title
anaulin
approved these changes
Sep 28, 2023
|
You can add exceptions for the newly-failing files if you want, and check this in. That way you are making some progress, but don't need to sink a bunch of time into fixing all these other occurrences. |
|
Yea, we have some work to do to clean up how we're using links and buttons. It was my second project using ViewComponent and Turbo; and I basically brute-forced things to work. But getting to the point where buttons == change data and display and links == change display will be a huge win. Probably not the most urgent project but something to look out for as we make other changes. |
rosschapman
force-pushed
the
match-click-selectors-with-html
branch
from
d6c4f9e to
0f1ab2a
Compare
|
Wooo! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #1848 (comment)
The difference between buttons and links are syntactically and semantically confusing. I would love to better understand the accessibility standards around this. Having some expertise here would be helpful. But until we dig into that, what I was thinking is that we could force the developer into a syntactically correct choice to remove any ambiguity in the code about whether an element is a
<button>or<a>.