Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Novosibirsk PDF #68

Merged
merged 19 commits into from
Apr 1, 2024
Merged

feat: add Novosibirsk PDF #68

merged 19 commits into from
Apr 1, 2024

Conversation

ikrommyd
Copy link
Contributor

@ikrommyd ikrommyd commented Mar 27, 2024 •
edited
Loading

Adds Novosibirsk PDF
Related to zfit/zfit#512

Proposed Changes

  • Add Novosibirsk PDF

Tests added

  • tests/test_pdf_novosibirsk.py

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

@ikrommyd ikrommyd mentioned this pull request Mar 28, 2024
Merged
jonas-eschle
jonas-eschle reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (minor things only)

zfit_physics/models/pdf_novosibirsk.py Show resolved Hide resolved
zfit_physics/models/pdf_novosibirsk.py Outdated Show resolved Hide resolved
zfit_physics/models/pdf_novosibirsk.py Outdated Show resolved Hide resolved
zfit_physics/models/pdf_novosibirsk.py Outdated Show resolved Hide resolved
jonas-eschle
jonas-eschle approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, I think the reverting was missing to revert parts of the commit?

zfit_physics/models/pdf_novosibirsk.py Outdated Show resolved Hide resolved
@jonas-eschle jonas-eschle self-requested a review April 1, 2024 20:51
jonas-eschle
jonas-eschle approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests! LGTM

@ikrommyd ikrommyd merged commit 2a8f217 into develop Apr 1, 2024
10 of 12 checks passed
@ikrommyd ikrommyd deleted the ikrommyd/novosibirsk branch April 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-eschle jonas-eschle jonas-eschle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikrommyd @jonas-eschle