Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use micromamba and uv and also install ROOT #69

Merged
merged 20 commits into from
Mar 28, 2024
Merged

ci: use micromamba and uv and also install ROOT #69

merged 20 commits into from
Mar 28, 2024

Conversation

ikrommyd
Copy link
Contributor

No description provided.

@ikrommyd ikrommyd changed the title ci: use conda and also install ROOT ci: use micromamba and also install ROOT Mar 28, 2024
@ikrommyd ikrommyd requested a review from jonas-eschle March 28, 2024 00:41
matthewfeickert
matthewfeickert reviewed Mar 28, 2024
View reviewed changes
Copy link

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@ikrommyd
Copy link
Contributor Author

ikrommyd commented Mar 28, 2024 •
edited
Loading

@jonas-eschle please take a look and let me know if you're good with that change. I need it to write tests for #68 and may also make sense to add tests against ROOT for the other distributions we got. May also be a good change to do for zfit.

jonas-eschle
jonas-eschle approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, maybe switch to uv? But if that doesn't work out of the box, standard pip isn't wrong either, of course. Up to you, merge when your satisfied

.github/workflows/ci.yml Show resolved Hide resolved
@ikrommyd ikrommyd changed the title ci: use micromamba and also install ROOT ci: use micromamba and uv and also install ROOT Mar 28, 2024
@ikrommyd ikrommyd merged commit b6e1f3f into develop Mar 28, 2024
12 checks passed
@ikrommyd ikrommyd deleted the ikrommyd/root-in-ci branch March 28, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert matthewfeickert left review comments

@jonas-eschle jonas-eschle jonas-eschle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikrommyd @matthewfeickert @jonas-eschle