Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#350 NoMethodError: undefined method [] for nil #351

Merged
merged 2 commits into from
Sep 24, 2024
Merged

#350 NoMethodError: undefined method [] for nil #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7538642
#350 use `full_name`
Suban05 Sep 24, 2024
ac386f3
update `fbe`
Suban05 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ GEM
net-http
faraday-retry (2.2.1)
faraday (~> 2.0)
fbe (0.0.69)
fbe (0.0.70)
backtrace (> 0)
decoor (> 0)
factbase (> 0)
Expand Down
2 changes: 1 addition & 1 deletion judges/github-events/github-events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def self.comments_info(pr)
issue_comments.count { |comment| comment[:user][:id] != pr[:user][:id] },
comments_appreciated: count_appreciated_comments(pr, issue_comments, code_comments),
comments_resolved: Fbe.github_graph.resolved_conversations(
pr[:base][:repo][:owner][:login], pr[:base][:repo][:name], pr[:number]
pr[:base][:repo][:full_name].split('/').first, pr[:base][:repo][:name], pr[:number]
).count
}
end
Expand Down