Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#350 NoMethodError: undefined method [] for nil #351

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Sep 24, 2024

A field pr[:base][:repo][:owner] is not stable, sometimes I don't see it, for example an event with id 42193949105 (https://api.github.com/repos/zerocracy/judges-action/events)
I suggest using full_name, splitting it by / and using the first value.

Removed owner from the test data: zerocracy/fbe#102

fixes #350

@Suban05
Copy link
Contributor Author

Suban05 commented Sep 24, 2024

@Yegorov please review

@Suban05
Copy link
Contributor Author

Suban05 commented Sep 24, 2024

@yegor256 please merge

@yegor256 yegor256 merged commit 2c579f6 into zerocracy:master Sep 24, 2024
8 checks passed
@yegor256
Copy link
Member

@Suban05 thanks!

@0crat
Copy link

0crat commented Sep 24, 2024

@Suban05 Hey there! 👋 Thanks for your contribution, even though it was a bit small (only 4 hits-of-code). You've earned +4 points, but we had to make some adjustments: -4 for the low comment count (only 2) and -8 for the small code size. We bumped it up by +12 to keep you motivated. Remember, more code and more review comments can boost your points next time! Keep the contributions coming, and you might hit the max of 24 points. Your current balance is +123. Looking forward to your next commit! 💻

@0crat
Copy link

0crat commented Sep 24, 2024

@Yegorov Great job on your review! 🌟 You've added +4 points to your balance, bringing your total to +174. While we'd love to see more comments and hits-of-code next time, we appreciate your effort and look forward to your continued contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `[]' for nil
4 participants