Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang-tidy findings #435

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix clang-tidy findings #435

merged 2 commits into from
Nov 25, 2024
+16 −19

Commits on Nov 24, 2024

  1. Fix clang-tidy performance warnings 

    Addressed warnings:

- parameter is copied for each invocation but only used as a const
  reference
- do not use 'std::endl' with streams; use '\\n' instead

Furthermore, `performance-enum-size` warnings have been disabled. Broker
uses several enum types in types that are exchanged over the network.
Changing the enum types would be a breaking change on the wire format.
    @Neverlord
    Neverlord committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    4d9aa3b View commit details
    Browse the repository at this point in the history

  2. Fix invalid range clang-tidy findings 

    Fix occurrences of "The value '0' provided to the cast expression is not
in the valid range of values for 'p2p_message_type'."
    @Neverlord
    Neverlord committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    f30d897 View commit details
    Browse the repository at this point in the history