Fix clang-tidy findings #435
Merged
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed warnings: - parameter is copied for each invocation but only used as a const reference - do not use 'std::endl' with streams; use '\\n' instead Furthermore, `performance-enum-size` warnings have been disabled. Broker uses several enum types in types that are exchanged over the network. Changing the enum types would be a breaking change on the wire format.
Fix occurrences of "The value '0' provided to the cast expression is not in the valid range of values for 'p2p_message_type'."
timwoj
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #365.
See the commit messages for more context.