Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): add checks to ensure limits for compression #1536

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore(gpu): add checks to ensure limits for compression #1536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backends/tfhe-cuda-backend/cuda/src/crypto/keyswitch.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,12 @@ __host__ void host_packing_keyswitch_lwe_list_to_glwe(
uint32_t lwe_dimension_in, uint32_t glwe_dimension,
uint32_t polynomial_size, uint32_t base_log, uint32_t level_count,
uint32_t num_lwes) {

if (num_lwes > polynomial_size)
PANIC("Cuda error: too many LWEs to pack. The number of LWEs should be "
"smaller than "
"polynomial_size.")

cudaSetDevice(gpu_index);
int glwe_accumulator_size = (glwe_dimension + 1) * polynomial_size;

Expand Down
6 changes: 6 additions & 0 deletions backends/tfhe-cuda-backend/cuda/src/integer/compression/compression.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ host_integer_decompress(cudaStream_t *streams, uint32_t *gpu_indexes,
uint32_t indexes_array_size, void **bsks,
int_decompression<Torus> *mem_ptr) {

auto polynomial_size = mem_ptr->encryption_params.polynomial_size;
if (indexes_array_size > polynomial_size)
PANIC("Cuda error: too many LWEs to decompress. The number of LWEs should "
"be smaller than "
"polynomial_size.")

auto extracted_glwe = mem_ptr->tmp_extracted_glwe;
auto compression_params = mem_ptr->compression_params;
host_extract<Torus>(streams[0], gpu_indexes[0], extracted_glwe,
Expand Down
4 changes: 2 additions & 2 deletions tfhe/src/integer/gpu/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ pub unsafe fn decompress_integer_radix_async<T: UnsignedInteger, B: Numeric>(
pbs_level: DecompositionLevelCount,
storage_log_modulus: u32,
vec_indexes: &CudaVec<u32>,
num_blocks: u32,
num_lwes: u32,
) {
assert_eq!(
streams.gpu_indexes[0],
Expand Down Expand Up @@ -403,7 +403,7 @@ pub unsafe fn decompress_integer_radix_async<T: UnsignedInteger, B: Numeric>(
lwe_dimension.0 as u32,
pbs_level.0 as u32,
pbs_base_log.0 as u32,
num_blocks,
num_lwes,
message_modulus.0 as u32,
carry_modulus.0 as u32,
PBSType::Classical as u32,
Expand Down
Loading