Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): add checks to ensure limits for compression #1536

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore(gpu): add checks to ensure limits for compression #1536

merged 1 commit into from
Sep 19, 2024

Conversation

pdroalves
Copy link
Contributor

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/713

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2024
@pdroalves pdroalves force-pushed the pa/chore/compression_checks branch 2 times, most recently from 58275a6 to 1f01c2d Compare September 16, 2024 12:06
@pdroalves pdroalves changed the base branch from main to pa/feat/convert_compression September 16, 2024 12:06
Base automatically changed from pa/feat/convert_compression to main September 18, 2024 11:35
@pdroalves pdroalves force-pushed the pa/chore/compression_checks branch from 0037502 to 4194e6b Compare September 19, 2024 15:27
agnesLeroy
agnesLeroy approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@pdroalves
Copy link
Contributor Author

@agnesLeroy three tests failed but they are not related to this PR, so I will proceed and merge.

@pdroalves pdroalves merged commit faf2002 into main Sep 19, 2024
83 of 85 checks passed
@pdroalves pdroalves deleted the pa/chore/compression_checks branch September 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdroalves @agnesLeroy @zama-bot