Ensure all the required fields are populated in the html report for new flattened issues approach #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins Pipelines |
sanyamsinghal
requested review from
priyanshi-yb and
makalaaneesh
and removed request for
priyanshi-yb
| issue.Reason = strings.Split(issue.Reason, "on column -")[0] | ||
| default: | ||
| issue.Reason = sensitiveReason | ||
| if strings.HasPrefix(issue.Reason, sensitiveReason) { |
There was a problem hiding this comment.
pls test this logic manually once with callhome. @priyanshi-yb has a server that you can use to easily test.
| @@ -1235,7 +1237,7 @@ func fetchUnsupportedPlPgSQLObjects(schemaAnalysisReport utils.SchemaReport) []U | |||
| }) | |||
| } | |||
| feature := UnsupportedFeature{ | |||
| FeatureName: reason, | |||
| FeatureName: issueName, | |||
There was a problem hiding this comment.
This will have callhome/yugabyted implications, no? Do you want to keep it the same now (set it to reason), and we can discuss this later when dealing with callhome/yugabyted?
There was a problem hiding this comment.
The issue with grouping by reason(/description) anymore is that it is dynamic(%ss), having column info etc..
There will be new unnecessary groups if we go that route for different value of %s in each case.
migtests/tests/pg/omnibus/expected_files/expected_schema_analysis_report.json
Outdated
Show resolved
Hide resolved
migtests/tests/pg/omnibus/expected_files/expected_schema_analysis_report.json
Outdated
Show resolved
Hide resolved
…eason - adding new field 'Name' to analyzeSchemaIssue to store corresponding info from QueryIssue
…ll issue's description/reason
…e to start with 'Unsupported datatype' prefix
…e to start with 'Unsupported datatype' prefix
sanyamsinghal
force-pushed
the
sanyam/vet-assessment-issues
branch
from
d6f6608 to
62d82c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
This PR includes:
Describe if there are any user-facing changes
nothing as such, only text has changed for some of the issue fields (reported in assess and analyze)
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?