Ensure all the required fields are populated in the html report for n…

…ew flattened issues approach (#2190)

This PR includes:

- Having relevant value based on Issue field
- Populating Description and Name in all query issues
- Replacing AnalyzeSchemaIssue.Reason field to be equivalent QueryIssue.Description instead of QueryIssue.Name field
- QueryIssue.Description will only contain dynamic information, rest all fields mostly will be static.
- Detection issue in Callhome whose description have object info.
- Fixed all the automation tests based on the new strings(reason/description etc)

migtests/scripts/functions.sh

@@ -892,6 +892,7 @@ normalize_json() {
             .OptimalSelectConnectionsPerNode? = "IGNORED" |
             .OptimalInsertConnectionsPerNode? = "IGNORED" |
             .RowCount? = "IGNORED" |
+			.FeatureDescription? = "IGNORED" | # Ignore FeatureDescription instead of fixing it in all tests since it will be removed soon
 			.MigrationComplexityExplanation?= "IGNORED" |
             # Replace newline characters in SqlStatement with spaces
 			.SqlStatement? |= (

migtests/scripts/run-schema-migration.sh

@@ -95,7 +95,7 @@ main() {
 
 	step "Analyze schema."
 	analyze_schema --output-format json
-	compare_json_reports "${EXPORT_DIR}/reports/schema_analysis_report.json" "${TEST_DIR}/expected_files/expected_schema_analysis_report.json"
+	compare_json_reports "${TEST_DIR}/expected_files/expected_schema_analysis_report.json" "${EXPORT_DIR}/reports/schema_analysis_report.json"
 
 	step "Create target database."
 	run_ysql yugabyte "DROP DATABASE IF EXISTS ${TARGET_DB_NAME};"

migtests/tests/pg/assessment-report-test/expectedAssessmentReport.json

@@ -2902,7 +2902,7 @@
 			"MinimumVersionsFixedIn": null
 		},
 		{
-			"FeatureName": "Referenced type declaration of variables",
+			"FeatureName": "Referencing type declaration of variables",
 			"Objects": [
 				{
 					"ObjectType": "FUNCTION",

migtests/tests/pg/mgi/expected_files/expectedAssessmentReport.json

@@ -13420,7 +13420,7 @@
 	"UnsupportedQueryConstructs": null,
     "UnsupportedPlPgSqlObjects": [
 		{
-			"FeatureName": "Referenced type declaration of variables",
+			"FeatureName": "Referencing type declaration of variables",
 			"Objects": [
 				{
 					"ObjectType": "FUNCTION",

migtests/tests/pg/osm/expected_files/expected_schema_analysis_report.json

@@ -58,7 +58,7 @@
             "IssueType": "unsupported_datatypes",
             "ObjectType": "TABLE",
             "ObjectName": "public.osm_changeset",
-            "Reason": "Unsupported datatype - geometry on column - geom",
+            "Reason": "PostGIS datatypes are not yet supported in YugabyteDB. Affected column: geom and type: geometry.",
             "SqlStatement": "CREATE TABLE public.osm_changeset (id bigint NOT NULL, user_id bigint, created_at timestamp, min_lat numeric(10, 7), max_lat numeric(10, 7), min_lon numeric(10, 7), max_lon numeric(10, 7), closed_at timestamp, open boolean, num_changes int, user_name varchar(255), tags public.hstore, geom public.geometry(polygon, 4326)) WITH (colocation=false);",
             "FilePath": "/Users/priyanshigupta/Documents/voyager/yb-voyager/migtests/tests/pg/osm/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -70,7 +70,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "TABLE",
             "ObjectName": "public.osm_changeset",
-            "Reason": "Unsupported datatype for Live migration with fall-forward/fallback - public.hstore on column - tags",
+            "Reason": "Datatype not yet supported by voyager in live migration with fall-forward/fallback. Affected column: tags and type: public.hstore. These columns will be excluded when exporting and importing data in live migration workflows.",
             "SqlStatement": "CREATE TABLE public.osm_changeset (id bigint NOT NULL, user_id bigint, created_at timestamp, min_lat numeric(10, 7), max_lat numeric(10, 7), min_lon numeric(10, 7), max_lon numeric(10, 7), closed_at timestamp, open boolean, num_changes int, user_name varchar(255), tags public.hstore, geom public.geometry(polygon, 4326)) WITH (colocation=false);",
             "FilePath": "/Users/priyanshigupta/Documents/voyager/yb-voyager/migtests/tests/pg/osm/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -82,7 +82,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "INDEX",
             "ObjectName": "changeset_geom_gist ON public.osm_changeset",
-            "Reason": "Schema contains GIST index which is not supported.",
+            "Reason": "The schema contains an index with an access method 'GIST' which is not supported in YugabyteDB.",
             "SqlStatement": "CREATE INDEX changeset_geom_gist ON public.osm_changeset USING gist (geom);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/osm/export-dir/schema/tables/INDEXES_table.sql",
             "Suggestion": "",

migtests/tests/pg/pgtbrus/expected_files/expected_schema_analysis_report.json

@@ -63,7 +63,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "FOREIGN TABLE",
             "ObjectName": "public.f_c",
-            "Reason": "Foreign tables require manual intervention.",
+            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
             "SqlStatement": "CREATE FOREIGN TABLE public.f_c (     i integer NOT NULL,     t integer,     x text ) SERVER p10 OPTIONS (     table_name 'c' );",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
             "Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",
@@ -75,7 +75,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "FOREIGN TABLE",
             "ObjectName": "public.f_t",
-            "Reason": "Foreign tables require manual intervention.",
+            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
             "SqlStatement": "CREATE FOREIGN TABLE public.f_t (     i integer NOT NULL,     ts timestamp(0) with time zone DEFAULT now(),     j json,     t text,     e public.myenum,     c public.mycomposit ) SERVER p10 OPTIONS (     table_name 't' );",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
             "Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",
@@ -87,7 +87,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "TABLE",
             "ObjectName": "public.t",
-            "Reason": "Unsupported datatype for Live migration with fall-forward/fallback - public.mycomposit on column - c",
+            "Reason": "Datatype not yet supported by voyager in live migration with fall-forward/fallback. Affected column: c and type: public.mycomposit. These columns will be excluded when exporting and importing data in live migration workflows.",
             "SqlStatement": "CREATE TABLE public.t (\n    i integer NOT NULL,\n    ts timestamp(0) with time zone DEFAULT now(),\n    j json,\n    t text,\n    e public.myenum,\n    c public.mycomposit\n);",
             "FilePath": "/Users/priyanshigupta/Documents/voyager/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/table.sql",
             "Suggestion": "",