Fix: retrieving Migration UUID as early as possible in the commands

yb-voyager/cmd/analyzeSchema.go

@@ -1126,10 +1126,6 @@ func checkConversions(sqlInfoArr []sqlInfo, filePath string) {
 }
 
 func analyzeSchema() {
-	err := retrieveMigrationUUID()
-	if err != nil {
-		utils.ErrExit("failed to get migration UUID: %w", err)
-	}
 
 	utils.PrintAndLog("Analyzing schema for target YugabyteDB version %s\n", targetDbVersion)
 	schemaAnalysisStartedEvent := createSchemaAnalysisStartedEvent()
@@ -1290,9 +1286,13 @@ var analyzeSchemaCmd = &cobra.Command{
 		"For more details and examples, visit https://docs.yugabyte.com/preview/yugabyte-voyager/reference/schema-migration/analyze-schema/",
 	Long: ``,
 	PreRun: func(cmd *cobra.Command, args []string) {
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
 		validOutputFormats := []string{"html", "json", "txt", "xml"}
 		validateReportOutputFormat(validOutputFormats, analyzeSchemaReportFormat)
-		err := validateAndSetTargetDbVersionFlag()
+		err = validateAndSetTargetDbVersionFlag()
 		if err != nil {
 			utils.ErrExit("%v", err)
 		}

yb-voyager/cmd/assessMigrationBulkCommand.go

@@ -48,7 +48,11 @@ var assessMigrationBulkCmd = &cobra.Command{
 	Long:  "Bulk Assessment of multiple schemas across one or more Oracle database instances",
 
 	PreRun: func(cmd *cobra.Command, args []string) {
-		err := validateFleetConfigFile(fleetConfigPath)
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
+		err = validateFleetConfigFile(fleetConfigPath)
 		if err != nil {
 			utils.ErrExit("%s", err.Error())
 		}
@@ -156,11 +160,6 @@ func assessMigrationBulk() error {
 		return fmt.Errorf("failed to parse fleet config file: %w", err)
 	}
 
-	err = retrieveMigrationUUID()
-	if err != nil {
-		return fmt.Errorf("failed to get migration UUID: %w", err)
-	}
-
 	for _, dbConfig := range bulkAssessmentDBConfigs {
 		utils.PrintAndLog("\nAssessing '%s' schema", dbConfig.GetSchemaIdentifier())
 

yb-voyager/cmd/assessMigrationCommand.go

@@ -80,13 +80,18 @@ var assessMigrationCmd = &cobra.Command{
 	Long:  fmt.Sprintf("Assess the migration from source (%s) database to YugabyteDB.", strings.Join(assessMigrationSupportedDBTypes, ", ")),
 
 	PreRun: func(cmd *cobra.Command, args []string) {
+		CreateMigrationProjectIfNotExists(source.DBType, exportDir)
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
 		validateSourceDBTypeForAssessMigration()
 		setExportFlagsDefaults()
 		validateSourceSchema()
 		validatePortRange()
 		validateSSLMode()
 		validateOracleParams()
-		err := validateAndSetTargetDbVersionFlag()
+		err = validateAndSetTargetDbVersionFlag()
 		if err != nil {
 			utils.ErrExit("%v", err)
 		}
@@ -319,13 +324,6 @@ func assessMigration() (err error) {
 	schemaDir = filepath.Join(assessmentMetadataDir, "schema")
 
 	checkStartCleanForAssessMigration(assessmentMetadataDirFlag != "")
-	CreateMigrationProjectIfNotExists(source.DBType, exportDir)
-
-	err = retrieveMigrationUUID()
-	if err != nil {
-		return fmt.Errorf("failed to get migration UUID: %w", err)
-	}
-
 	utils.PrintAndLog("Assessing for migration to target YugabyteDB version %s\n", targetDbVersion)
 
 	assessmentDir := filepath.Join(exportDir, "assessment")

yb-voyager/cmd/endMigrationCommand.go

@@ -43,14 +43,19 @@ var endMigrationCmd = &cobra.Command{
 	Long:  "End the current migration and cleanup all metadata stored in databases(Target, Source-Replica and Source) and export-dir",
 
 	PreRun: func(cmd *cobra.Command, args []string) {
-		err := validateEndMigrationFlags(cmd)
+		if utils.IsDirectoryEmpty(exportDir) {
+			utils.ErrExit("export directory is empty, nothing to end")
+		}
+
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
+		err = validateEndMigrationFlags(cmd)
 		if err != nil {
 			utils.ErrExit(err.Error())
 		}
 
-		if utils.IsDirectoryEmpty(exportDir) {
-			utils.ErrExit("export directory is empty, nothing to end")
-		}
 	},
 
 	Run: endMigrationCommandFn,
@@ -76,7 +81,6 @@ func endMigrationCommandFn(cmd *cobra.Command, args []string) {
 		utils.ErrExit("error while checking streaming mode: %w\n", err)
 	}
 
-	retrieveMigrationUUID()
 	checkIfEndCommandCanBePerformed(msr)
 
 	// backing up the state from the export directory

yb-voyager/cmd/importData.go

@@ -81,7 +81,11 @@ var importDataCmd = &cobra.Command{
 			importerRole = TARGET_DB_IMPORTER_ROLE
 		}
 		sourceDBType = GetSourceDBTypeFromMSR()
-		err := validateImportFlags(cmd, importerRole)
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
+		err = validateImportFlags(cmd, importerRole)
 		if err != nil {
 			utils.ErrExit("Error: %s", err.Error())
 		}
@@ -132,11 +136,6 @@ func importDataCommandFn(cmd *cobra.Command, args []string) {
 		utils.ErrExit("Failed to get migration status record: %s", err)
 	}
 
-	err = retrieveMigrationUUID()
-	if err != nil {
-		utils.ErrExit("failed to get migration UUID: %w", err)
-	}
-
 	// Check if target DB has the required permissions
 	if tconf.RunGuardrailsChecks {
 		checkImportDataPermissions()

yb-voyager/cmd/importDataFileCommand.go

@@ -72,10 +72,13 @@ var importDataFileCmd = &cobra.Command{
 		sourceDBType = POSTGRESQL // dummy value - this command is not affected by it
 		sqlname.SourceDBType = sourceDBType
 		CreateMigrationProjectIfNotExists(sourceDBType, exportDir)
-
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
 		tconf.Schema = strings.ToLower(tconf.Schema)
 		tdb = tgtdb.NewTargetDB(&tconf)
-		err := tdb.Init()
+		err = tdb.Init()
 		if err != nil {
 			utils.ErrExit("Failed to initialize the target DB: %s", err)
 		}
@@ -91,10 +94,6 @@ var importDataFileCmd = &cobra.Command{
 		dataStore = datastore.NewDataStore(dataDir)
 		importFileTasks := prepareImportFileTasks()
 		prepareForImportDataCmd(importFileTasks)
-		err := retrieveMigrationUUID()
-		if err != nil {
-			utils.ErrExit("failed to get migration UUID: %w", err)
-		}
 		importData(importFileTasks)
 		packAndSendImportDataFilePayload(COMPLETE)
 

yb-voyager/cmd/importSchema.go

@@ -47,8 +47,12 @@ var importSchemaCmd = &cobra.Command{
 		if tconf.TargetDBType == "" {
 			tconf.TargetDBType = YUGABYTEDB
 		}
+		err := retrieveMigrationUUID()
+		if err != nil {
+			utils.ErrExit("failed to get migration UUID: %w", err)
+		}
 		sourceDBType = GetSourceDBTypeFromMSR()
-		err := validateImportFlags(cmd, TARGET_DB_IMPORTER_ROLE)
+		err = validateImportFlags(cmd, TARGET_DB_IMPORTER_ROLE)
 		if err != nil {
 			utils.ErrExit("Error: %s", err.Error())
 		}
@@ -79,10 +83,6 @@ var flagRefreshMViews utils.BoolStr
 var invalidTargetIndexesCache map[string]bool
 
 func importSchema() error {
-	err := retrieveMigrationUUID()
-	if err != nil {
-		return fmt.Errorf("failed to get migration UUID: %w", err)
-	}
 
 	tconf.Schema = strings.ToLower(tconf.Schema)
 
@@ -93,7 +93,7 @@ func importSchema() error {
 		// available always and this is just for initialisation of tdb and marking it nil again back.
 		tconf.Schema = "public"
 		tdb = tgtdb.NewTargetDB(&tconf)
-		err = tdb.Init()
+		err := tdb.Init()
 		if err != nil {
 			utils.ErrExit("Failed to initialize the target DB: %s", err)
 		}

yb-voyager/src/callhome/diagnostics.go

@@ -58,7 +58,7 @@ CREATE TABLE diagnostics (
 	migration_type TEXT,
 	time_taken_sec int,
 	status TEXT,
-	host_ip character varying 255 -- set by the callhome service
+	host_ip character varying (255), -- set in callhome service
 	PRIMARY KEY (migration_uuid, migration_phase, collected_at)
 
 );