Fix: retrieving Migration UUID as early as possible in the commands #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makalaaneesh
reviewed
Jan 8, 2025
| @@ -81,7 +81,11 @@ var importDataCmd = &cobra.Command{ | |||
| importerRole = TARGET_DB_IMPORTER_ROLE | |||
| } | |||
| sourceDBType = GetSourceDBTypeFromMSR() | |||
| err := validateImportFlags(cmd, importerRole) | |||
| err := retrieveMigrationUUID() | |||
There was a problem hiding this comment.
can we do this above GetSourceDBTypeFromMSR ? that also ErrExits.
| @@ -47,8 +47,12 @@ var importSchemaCmd = &cobra.Command{ | |||
| if tconf.TargetDBType == "" { | |||
| tconf.TargetDBType = YUGABYTEDB | |||
| } | |||
| err := retrieveMigrationUUID() | |||
There was a problem hiding this comment.
Might be slightly unrelated question, but at this point what if export-dir is empty and user runs import-schema? What happens then?
Same question for import-data, analyze-schema as well..
There was a problem hiding this comment.
In case of empty dirs and these commands we already have other checks just before this that checks if export-dir is initiated. And we can't do much in those cases we will still get the 00000... uuid in callhome
There was a problem hiding this comment.
got it, but i guess now we will get the error message, so that should be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Fixes retrieving the migration uuid as early as possible to be able send the diagnosis to callhome with proper uuid.
Describe if there are any user-facing changes
How was this pull request tested?
already available tests
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4426
Does your PR have changes that can cause upgrade issues?