Fix freezes #1181
Merged
Fix freezes #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1181 +/- ##
==========================================
- Coverage 36.35% 36.34% -0.02%
==========================================
Files 50 50
Lines 11469 11471 +2
==========================================
- Hits 4170 4169 -1
- Misses 7299 7302 +3
|
This was referenced Feb 6, 2024
Instead of change window attributes back and forth, calculate the evmask and set it just once. And also make sure the request is flushed. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
There was a problem hiding this comment.
looks good, builds and works for me. and the most importantly, fixes the issue.
two more things:
- there is a typo in the
event: fix dumb bug in repair_wincommit's message: "is show_all_xerrors is set"; - it may also fix the New backend causes occasional stutter/dropped updates #1040 (see Picom stops drawing during games, until alt-tab #1145 (comment)).
nitpicking session ended
yshui
force-pushed
the
defroster
branch
2 times, most recently
from
a3aa275
to
7c357f7
Compare
Basically we won't call xcb_damage_subtract if show_all_xerrors is set, which is very bad. Fixes that, and also make sure the damage subtract request is flushed in all branches. Fixes: 1307d9e Signed-off-by: Yuxuan Shui <[email protected]>
See the added comments for details. Fixes #1145 Fixes #1166 Fixes #1040? Signed-off-by: Yuxuan Shui <[email protected]>
absolutelynothelix
added a commit
that referenced
this pull request
Feb 29, 2024
a follow-up for #1181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the idea we discussed on discord. I also look through
ev_handleto make sure requests are flushed.