refactor: refactor services and clients #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lients # Conflicts: # frontend/src/App.vue # frontend/src/components/Simulator/ConstructorParameters.vue # frontend/src/components/Simulator/ContractMethodItem.vue # frontend/src/hooks/useInputMap.ts # frontend/src/main.ts # frontend/src/stores/contracts.ts # frontend/src/utils/store.ts
This was
linked to
issues
Aug 28, 2024
denishacquin
changed the title
denishacquin
changed the title
added 2 commits
August 29, 2024 12:15
…ents # Conflicts: # frontend/src/components/Simulator/CodeEditor.vue # frontend/src/stores/contracts.ts
cristiam86
requested changes
Aug 29, 2024
There was a problem hiding this comment.
@denishacquin great work! I love seeing the utils getting nuked! but I wonders if everything should be a hook as I understand that those are mostly about dynamic values
cristiam86
requested changes
Aug 30, 2024
cristiam86
approved these changes
Aug 30, 2024
cristiam86
approved these changes
Aug 30, 2024
Merged
cristiam86
added a commit
that referenced
this pull request
Sep 4, 2024
## What's Changed * feat: various frontend improvements by @denishacquin in #418 * fix: 409 sim fe alow horizontal scroll when there is syntax error in the contract by @denishacquin in #430 * ci: gh action to validate pr title by @AgustinRamiroDiaz in #429 * refactor: refactor services and clients by @denishacquin in #419 * docs: updated contributing by @cristiam86 in #421 * feat: 417 sim fe allow re ordering contract tabs by dragging them around by @denishacquin in #434 * test: 425 frontend unit testing by @denishacquin in #426 * chore(backend): refactor database connector to use sqlalchemy by @AgustinRamiroDiaz in #420 * chore(github): update PR template by @AgustinRamiroDiaz in #457 **Full Changelog**: v0.3.2...0.4.0
AgustinRamiroDiaz
pushed a commit
that referenced
this pull request
Sep 9, 2024
* refactor: convert rpc client to a hook instead of provide/inject * refactor: web3 hook * refactor: short address hook * refactor: db hook * fix: remove db version redundancy * refactor: ws hook * refactor: rpc client/hook * refactor: input map hook, move useContractQueries to hooks index * refactor: python syntax hook * refactor: filename hook * refactor: setup stores * refactor: rename eth to wallet * fix: wrong input mapping * refactor: normalize naming for wallet methods * fix: update omitted replace * fix: replace updated method * fix: consistently delete example contracts on reset storage * fix: don't reload all example files when they already exist with a change * fix: remove comment * fix: allow id param on tx items * fix: load opened files correctly from storage, remove some legacy code * refactor: move shortenAddress to useWallet hook and simplify it's definition * refactor: move python syntax to a constant * refactor: web client * refactor: wrap web3 methods * fix: adapt implementations after web3 wallet wrapping * fix: use lodash debounce instead of vue-debounce because of breaking deps in testing * fix: wrong typing --------- Co-authored-by: Den <[email protected]> Co-authored-by: Den <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
Fixes #413
Fixes #412
What
Why
Testing done
Checks
Tips for reviewing
User facing release notes