Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIM-FE-Refactor services and clients #408

Closed
denishacquin opened this issue Aug 20, 2024 · 2 comments · Fixed by #419
Closed

SIM-FE-Refactor services and clients #408

denishacquin opened this issue Aug 20, 2024 · 2 comments · Fixed by #419
Assignees
@denishacquin

Comments

@denishacquin
Copy link
Contributor

This should be done mainly for external libraries and clients such as Viem and the Simulator's backend
The way it should be architected is following the following pattern
UI Components -> Hooks -> Services -> Clients.
We should enforce unit testing mostly on Hooks and Services.

Also, please take this opportunity to add unit tests.
@denishacquin denishacquin self-assigned this Aug 20, 2024
@denishacquin
Copy link
Contributor Author

I'm not sure I really understand this. Let's discuss it together @cristiam86

@denishacquin denishacquin linked a pull request Aug 28, 2024 that will close this issue
refactor: refactor services and clients #419
Merged
3 tasks
@denishacquin denishacquin mentioned this issue Aug 28, 2024
Merged
3 tasks
@denishacquin
Copy link
Contributor Author

Moving unit testing to separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denishacquin denishacquin

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@denishacquin