211 SIM-OPS-Generate PR from staging to main with changelog #335
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #335 +/- ##
=========================================
Coverage ? 2.28%
=========================================
Files ? 73
Lines ? 6613
Branches ? 75
=========================================
Hits ? 151
Misses ? 6390
Partials ? 72 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
Signed-off-by: Agustín Ramiro Díaz <[email protected]>
AgustinRamiroDiaz
force-pushed
the
211-sim-ops-generate-pr-from-staging-to-main-with-changelog
branch
from
14e8088 to
e483c63
Compare
| id: generate_release_notes | ||
| # https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#generate-release-notes-content-for-a-release | ||
| run: | | ||
| response=$(curl -L \ |
There was a problem hiding this comment.
What if this curl command will fail from some rate-limiting rule? How to handle such errors?
There was a problem hiding this comment.
This hasn't failed for me in my tests. I think for now we can go forward by just retrying the action manually if it fails and addressing it in a fix PR. I don't think we should complicate it now :)
| https://api.github.com/repos/yeagerai/genlayer-simulator/releases/generate-notes \ | ||
| -d '{"tag_name":"${{ steps.extract_tag.outputs.tag }}","target_commitish":"${{ steps.extract_branch.outputs.branch }}","previous_tag_name":"${{ steps.get_latest_release.outputs.tag}}"}' ) | ||
| echo $response | ||
|
|
There was a problem hiding this comment.
Can you use https://github.com/marketplace/actions/release-notes-generator instead of this?
There was a problem hiding this comment.
First time I see that one, but I've researched a lot about tools to automate this and I didn't find anyone that would satisfy our needs. All of them had little to no flexibility to customize them.
For example, the one you are sharing here only works with "milestones"
Do you know how to use it for this use case?
We need to create release notes when there's a release branch created, and add those notes to a PR body
cristiam86
deleted the
211-sim-ops-generate-pr-from-staging-to-main-with-changelog
branch
Fixes #211
What
release-<semver>, like for examplerelease-v1.2.3Why
Testing done
I've created the branch
release-testfrom this branch andDecisions made
I decided to go with branch push as trigger instead of
workflow_dispatchbecause I feel it's more comfortable, but I can change that if you think it's more comfortable to do it in the UIChecks
Reviewing tips
GitHub API and CLI docs are very useful