Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

334 SIM-generate releases and versions when merging to main #336

Conversation

AgustinRamiroDiaz
Copy link
Contributor

@AgustinRamiroDiaz AgustinRamiroDiaz commented Jul 25, 2024

Fixes ##334

What

  • Automatically creates GH Releases from main branch

Why

  • to automate a manual task

Testing done

  • Manually called gh release create $semver --title $semver -F body.txt --prerelease locally and it worked as expected

Decisions made

I've left the prerelease flag since I don't have a way to test this end to end. Once we see that it works as expected I'll remove it

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set the PR name to the issue name

Reviewing tips

This PR depends on a specific format from the commits, which will go in combo with #335

Signed-off-by: Agustín Ramiro Díaz <[email protected]>
@AgustinRamiroDiaz AgustinRamiroDiaz linked an issue Jul 25, 2024 that may be closed by this pull request
@AgustinRamiroDiaz AgustinRamiroDiaz force-pushed the 334-sim-generate-releases-and-versions-when-merging-to-main branch from 0005cd1 to 3e00afe Compare July 25, 2024 18:10
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.58%. Comparing base (27c4006) to head (3e00afe).
Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #336   +/-   ##
=====================================
  Coverage   2.58%   2.58%           
=====================================
  Files         73      73           
  Lines       5761    5761           
  Branches      75      75           
=====================================
  Hits         149     149           
  Misses      5540    5540           
  Partials      72      72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cristiam86
cristiam86 previously approved these changes Jul 29, 2024
@AgustinRamiroDiaz AgustinRamiroDiaz changed the base branch from main to staging July 29, 2024 17:10
@AgustinRamiroDiaz AgustinRamiroDiaz dismissed cristiam86’s stale review July 29, 2024 17:10

The base branch was changed.

@AgustinRamiroDiaz AgustinRamiroDiaz merged commit bcb95a8 into staging Jul 29, 2024
14 of 16 checks passed
@cristiam86 cristiam86 deleted the 334-sim-generate-releases-and-versions-when-merging-to-main branch August 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-generate releases and versions when merging to main
2 participants