Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mongocxx dependencies to all dev environments #218

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

gibber9809
Copy link
Contributor

Description

This PR adds mongocxx dependencies to each dev environment. These changes have been separated out from the following PR for the reducer so that we can update the environment used by the CI.

Validation performed

  • validated that reducer builds successfully in ubuntu focal, ubuntu jammy, and centos7.4 docker containers
  • unable to validate build on macos

@kirkrodrigues
Copy link
Member

Centos build failure unrelated to PR. Caused by boostorg/boost#842. That said, we should add set -e to the install scripts so that they terminate earlier on error.

Copy link
Contributor Author

@gibber9809 gibber9809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor refactors lgtm

@kirkrodrigues kirkrodrigues merged commit efc34ae into y-scope:main Jan 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants