Dependency fixes for CLP core: #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix static linking for mongoc and mongocxx to allow linked exes to run in the execution container. - Use apt's prebuilt mariadb-c-connector in the execution container.
wraymo
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#218 added mongocxx to CLP-core's dependency container images, but trying to run executables linked with mongocxx in the execution container, we found that it was trying to load the dynamic library for mongoc. Upon fixing the installation script for mongocxx to make it link with the static mongoc, we found that mongoc was dynamically linking with icuuc. So this PR also fixes mongoc's installation script to not link with libicu.
This PR also switches the execution container from using a prebuilt mariadb-c-connector from mariadb.com to one from Ubuntu's apt repositories; this is to match the Ubuntu focal dependency container image.
Validation performed
Started the clp-core-dependencies-x86-ubuntu-focal container
Uninstalled mongoc and mongocxx:
Installed mongoc and mongocxx using the new installation scripts:
Built a binary that links with monogcxx
Started the clp-execution-x86-ubuntu-focal container
Validated that the binary built above could run successfully.