Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing thread safe groups libxmtp PR #350

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Testing thread safe groups libxmtp PR #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e220cf8
update to libxmtp 7473a24
cameronvoell Dec 12, 2024
943c9b1
set consent to null when syncing all conversations
cameronvoell Dec 12, 2024
46aeca9
fix test
cameronvoell Dec 13, 2024
50cf55e
add replacing semaphore with mutex changes
mchenani Dec 13, 2024
b9c64bc
update branch to point to libxmtp ba0b09c
cameronvoell Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ class GroupTest {

assertEquals(alixGroup.messages().size, 1)
assertEquals(alixGroup2.messages().size, 1)
assertEquals(numGroups, 3u)
assertEquals(numGroups, 2u)

runBlocking {
boGroup2.removeMembers(listOf(alix.walletAddress))
Expand All @@ -939,12 +939,12 @@ class GroupTest {
assertEquals(alixGroup.messages().size, 3)
assertEquals(alixGroup2.messages().size, 2)
// First syncAllGroups after remove includes the group you're removed from
assertEquals(numGroups, 3u)
assertEquals(numGroups, 2u)

runBlocking {
numGroups = alixClient.conversations.syncAllConversations()
}
// Next syncAllGroups will not include the inactive group
assertEquals(numGroups, 2u)
assertEquals(numGroups, 1u)
}
}
6 changes: 3 additions & 3 deletions library/src/main/java/libxmtp-version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 3103e7b9
Branch: main
Date: 2024-12-05 00:24:03 +0000
Version: ba0b09cf
Branch: mc/thread-safe-groups
Date: 2024-12-13 16:39:08 +0000
2 changes: 1 addition & 1 deletion library/src/main/java/org/xmtp/android/library/Conversations.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ data class Conversations(

// Sync all new and existing conversations data from the network
suspend fun syncAllConversations(): UInt {
return ffiConversations.syncAllConversations()
return ffiConversations.syncAllConversations(null)
}

suspend fun newConversation(peerAddress: String): Conversation {
Expand Down
Loading
Loading