Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing thread safe groups libxmtp PR #350

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cameronvoell
Copy link
Contributor

This branch is testing libxmtp PR xmtp/libxmtp#1404

currently set to libxmtp commit 7473a2462b98bd79afa469ea8940cc1c029bda69

@cameronvoell
Copy link
Contributor Author

See log from failing test testCanStreamGroups from file library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt

@Test
fun testCanStreamGroups() = kotlinx.coroutines.test.runTest {
boClient.conversations.stream(type = ConversationType.GROUPS).test {
val group =
alixClient.conversations.newGroup(listOf(bo.walletAddress))
assertEquals(group.id, awaitItem().id)
val group2 =
caroClient.conversations.newGroup(listOf(bo.walletAddress))
assertEquals(group2.id, awaitItem().id)
}
}

Log excerpt before crash:

12-12 17:49:23.388  9855  9879 I xmtpv3  : async-compat/tokio-1 retry: xmtp_mls::storage::encrypted_store::group: Trying to insert group
12-12 17:49:23.388  9855  9879 I xmtpv3  : async-compat/tokio-1 retry: xmtp_mls::storage::encrypted_store::group: Group is inserted
12-12 17:49:23.388  9855  9879 W xmtpv3  : async-compat/tokio-1 retry: xmtp_mls::storage::encrypted_store::private: More than 1 strong connection references still exist during async transaction
12-12 17:49:23.390  9855  9879 D xmtpv3  : async-compat/tokio-1 retry: xmtp_mls::storage::encrypted_store::private: Transaction async being committed
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read Tree
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read_list ProposalQueueRefs
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read GroupContext
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read InterimTranscriptHash
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read ConfirmationTag
12-12 17:49:23.391  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read EpochSecrets
12-12 17:49:23.392  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read OwnLeafNodeIndex
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read MessageSecrets
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read ResumptionPskStore
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read MlsGroupJoinConfig
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: own_leaf_nodes
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read_list OwnLeafNodes
12-12 17:49:23.393  9855  9879 D xmtpv3  : async-compat/tokio-1 load_mls_group_with_lock_async: xmtp_mls::storage::sql_key_store: read GroupState
12-12 17:49:23.393  9855  9879 I xmtpv3  : async-compat/tokio-1 xmtp_mls::subscriptions: Trigger conversation callback
12-12 17:49:23.396  9855  9879 D xmtpv3  : async-compat/tokio-1 xmtp_mls::storage::encrypted_store::native: Pulling connection from pool, idle_connections=25, total_connections=25
--------- beginning of crash
12-12 17:49:23.397  9855  9879 F libc    : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 9879 (Thread-52), pid 9855 (id.library.test)

full log:
test-logcat-2024-12-12_17-48-31.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants