Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 x 1 picking viewport #1168

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

Kurtil
Copy link
Contributor

@Kurtil Kurtil commented Oct 9, 2023

Picking with a 1 x 1 viewport. I used the clip position remapping method used by @tmarti for the snap picking.

I've fixed the precision issue with commit e9549ca so I edited this description - @xeolabs

@Kurtil
Copy link
Contributor Author

Kurtil commented Oct 9, 2023

Ray picking precision issue #1105.

@Kurtil
Copy link
Contributor Author

Kurtil commented Oct 9, 2023

Merging this PR may close #1076 and #513.

@ghost
Copy link

ghost commented Oct 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@xeolabs
Copy link
Member

xeolabs commented Oct 11, 2023

@Kurtil is BIMData depending on ray-picking functionality (with origin->ray) ? I don't even know of any users who are actually depending on ray-picking, so if that can't be fixed, I'd be in favour of removing ray-picking altogether, if that stands in the way of faster surface picking with canvas coordinates (enabled by this PR). Fast model interaction is always our top priority (and canvas surface picking is a big part of that, since it's used by camera interaction).

@Amoki
Copy link
Contributor

Amoki commented Oct 11, 2023

We use ray pick to implement a laser measurement giving the distance between two objects.

@xeolabs xeolabs merged commit ffd9fb6 into xeokit:master Oct 12, 2023
@xeolabs
Copy link
Member

xeolabs commented Oct 12, 2023

@Kurtil I've fixed the precision issue while doing a merge conflict fix: e9549ca

@xeolabs xeolabs added this to the 2.4.0 milestone Oct 12, 2023
@Kurtil Kurtil deleted the core/pickingPerformance branch October 13, 2023 07:18
@tmarti
Copy link
Contributor

tmarti commented Oct 14, 2023

@xeolabs at Tribia we're also depending on ray picking for laser mesurements, plus some custom functionalities for obtaining the ifc-storey and ifc-space where the camera is! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants