Draw pick normal using 32 bits per color channel instead of default 8 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the pick normal precision fix this issue : #523
Before: (section plane not exactly parallel to the clicked surface)
After: (section plane exactly parallel to the clicked surface)
Implementation:
It uses another framebuffer instead of the previously used pick frame buffer for picking normals. The new framebuffer uses a RGBA32I color renderable texture.
It uses more VRAM but once the 1 x 1 picking viewport PR will be merged, the difference won't be relevant.
Noticeable difference:
Because of the new normal encoding, the missing normal issue does not appear the same way. Before, the normalised missing normal could be closed to [zero, zero, zero] or [NaN, NaN, NaN] OS dependent, but now it is only [NaN, NaN, NaN]...