LACP support #9
Closed
LACP support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
reviewed
Jan 13, 2023
Signed-off-by: Yann Dirson <[email protected]>
This will allow for more concise logic.
stormi
reviewed
Jan 13, 2023
stormi
reviewed
Jan 13, 2023
ydirson
force-pushed
the
lacp
branch
3 times, most recently
from
c2e1193 to
98396b0
Compare
Always safer, and will facilitate further splitting
|
Working on answerfile shows exacerbated need to pass a NIC object to NetInterface ctor (instead of "just hwaddr" initially, getting to which we now add bonding parameters). The only call sites for which conversion is still not obvious to me are the ones in |
Signed-off-by: Yann Dirson <[email protected]>
This check was already not very useful, as if an eth device is not in getNetifList(), the ifup command will just fail properly. But in the case of a bond interface, the bond device will not even exist before running ifup. Signed-off-by: Yann Dirson <[email protected]>
This is a prerequisite to allowing more than just eth* Signed-off-by: Yann Dirson <[email protected]>
Less complexity for the nominal case, and makes it easier to add different non-nominal cases. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
…rpart Don't repeat all parameters on the deprecated version, as we're going to add more options. Signed-off-by: Yann Dirson <[email protected]>
Using 1 name for 2 concepts is a bad idea, especially in a single function. Also nukes one line of dead code. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]> (cherry picked from commit 50ecc56)
For bonding support we'll add more fields to NIC, that NetInterface needs to know about.
FIXME: - maybe support DebStyleInterface ? how would we test ?
Signed-off-by: Yann Dirson <[email protected]>
Bonding configuration created from commandline cannot be properly passed to the UI, which needs it both for netinstall and host-management, so we have to re-discover the existing configuration to present it to the user. This includes identifying the configured bonding interface, and filtering out their member interfaces from available choices. This is not very satisfying, and we may want to improve the overall installer architecture to make this better in the future, but it would be way out of scope here. Signed-off-by: Yann Dirson <[email protected]>
We'll call them from upcoming lacp_bond_ui().
Making things visible is good (esp. here it allows to check interface details), especially once we add the ability to create a bond interface. Signed-off-by: Yann Dirson <[email protected]>
Works at selectNetif level, and as such applies both to installer and host-management networt configs.
Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
lacp
branch
3 times, most recently
from
9e3a7b1 to
df5bed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: submitted upstream
This branch deals with the installer side of things, firstboot data needs to be handled in XAPI, for which we depend on xapi-project/xen-api#4333:
Known limitations we may want to address:
ifcfg-*files without an IP config.This PR explicitly does not deal with:
ExistingInstallation.readSettings()), to whichnetwork_dbseems to be unable to report about bonding (but the impact seems to be limited to default values). The system's bonds are already preserved on upgrade, though.What the screens currently look like: