[WiP] add possibility to configure lacp bonding at install #25
Conversation
| @@ -69,6 +69,13 @@ def __init__(self, mode, hwaddr, ipaddr=None, netmask=None, gateway=None, | |||
| self.ipv6addr = None | |||
| self.ipv6_gateway = None | |||
|
|
|||
| if bond_mode is not None: | |||
| # Not `balance-slb` because it's openvswitch specific | |||
| assert bond_mode in ["lacp", "active-backup"] | |||
There was a problem hiding this comment.
What if the users provided a different value? How will the error be displayed to them?
There was a problem hiding this comment.
idk, i've reproduced how such errors are handled in the code.
The UI won't allow to give other values. The answerfiles think will be handled in answerfile.py so this is not where to treat user error display.
There was a problem hiding this comment.
Ok, so this means you'll sanitize answerfile input so that those asserts are never reached?
There was a problem hiding this comment.
Yes, once i'm tackling this part in the parsong of the answerfile.
|
Yes upstream our changes would be nice. |
|
Obsoleted by xcp-ng/host-installer#9 |
No description provided.