Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micro-optimizations] Minor Chunk rendering + shader optimizations #518

Closed
wants to merge 19 commits into from

Conversation

thr3343
Copy link
Contributor

@thr3343 thr3343 commented Oct 6, 2024

Mix of assorted optimization patches that were too small a justify a PR on their own

Had these patches lying around for a long while now, so decided to combine them together into one PR instead

Will likely not provide more than a +10% FPS improvement at most, however these optimizations have the key advantage of having no effect on visuals, making them effectively free

@deprale
Copy link

deprale commented Oct 22, 2024

LGTM :) Thanks for your efforts.

Also improves DrawBuffers class cache line alignment (32 bytes instead of 40)
@thr3343
Copy link
Contributor Author

thr3343 commented Nov 15, 2024

Parts of this PR are redundant, as some of these optimizations have been added to upstream in a different form
(Namely 6c4fe7d, which has the same benefit as Optimize Entity lighting),
There's also a few minor visual artifacts (i.e. bugs) I failed to notice during testing (Spider shader is visually incorrect)

Also has alot of merge conflicts upstream, so will close and reopen at a later time (likely in a few days)

@thr3343 thr3343 closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants