Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Outdated) [Micro-optimizations] Minor Chunk rendering + shader optimizations #508

Closed
wants to merge 21 commits into from

Conversation

thr3343
Copy link
Contributor

@thr3343 thr3343 commented Sep 11, 2024

Edit: Messed up the commit history when porting the PR to 1.21 (i.e. Bad branch rebase)
So the new PR is here: #518, sorry about the inconvenience

Mix of assorted optimisation patches that were too small a justify a PR on their own

Had these patches lying around for a long while now, so decided to combine them together into one PR instead

Will likely not provide more than a +10% FPS improvement at most, but with the advantage of having no effect on visuals, making them effectively free

thr3343 and others added 9 commits August 13, 2024 12:39
- Remove GuiBatchRenderer
- Add batching support to GuiRenderer
Uses ALPHA_CUTOUT SpecConstant to bake constant values into the shader

Which bypasses a uniform read + reduces required descriptor updates for terrain
Based on rendertype_entity_translucent_cull
@thr3343 thr3343 changed the base branch from 1.20.x to 1.21 October 5, 2024 17:38
@thr3343
Copy link
Contributor Author

thr3343 commented Oct 6, 2024

I suck with Git, so didn't rebase this PR to 1.21 properly (The commit history is all messed up, and merged the branch onto itself by accident)

So will close and reopen this in a few minutes or so, with a corrected and cleaned up commit history

Edit: just reopened it now, #518, sorry about that

@thr3343 thr3343 closed this Oct 6, 2024
@thr3343 thr3343 changed the title [Micro-optimizations] Minor Chunk rendering + shader optimizations (Outdated) [Micro-optimizations] Minor Chunk rendering + shader optimizations Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants