-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Outdated) [Micro-optimizations] Minor Chunk rendering + shader optimizations #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove GuiBatchRenderer - Add batching support to GuiRenderer
Uses ALPHA_CUTOUT SpecConstant to bake constant values into the shader Which bypasses a uniform read + reduces required descriptor updates for terrain
Based on rendertype_entity_translucent_cull
thr3343
force-pushed
the
PerfPatches2
branch
from
September 23, 2024 21:48
1cfe8f8
to
52cc289
Compare
I suck with Git, so didn't rebase this PR to 1.21 properly (The commit history is all messed up, and merged the branch onto itself by accident) So will close and reopen this in a few minutes or so, with a corrected and cleaned up commit history Edit: just reopened it now, #518, sorry about that |
thr3343
changed the title
[Micro-optimizations] Minor Chunk rendering + shader optimizations
(Outdated) [Micro-optimizations] Minor Chunk rendering + shader optimizations
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Messed up the commit history when porting the PR to 1.21 (i.e. Bad branch rebase)
So the new PR is here: #518, sorry about the inconvenience
Mix of assorted optimisation patches that were too small a justify a PR on their own
Had these patches lying around for a long while now, so decided to combine them together into one PR instead
Will likely not provide more than a +10% FPS improvement at most, but with the advantage of having no effect on visuals, making them effectively free