-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for claim-wise uniqueness validation #6113
Add support for claim-wise uniqueness validation #6113
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6113 +/- ##
============================================
+ Coverage 44.66% 45.42% +0.75%
- Complexity 13476 14304 +828
============================================
Files 1578 1620 +42
Lines 98710 104694 +5984
Branches 16016 17540 +1524
============================================
+ Hits 44088 47555 +3467
- Misses 48005 50192 +2187
- Partials 6617 6947 +330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5a4769a
to
89624e0
Compare
89624e0
to
5f716bc
Compare
5f716bc
to
8116bea
Compare
8116bea
to
d37616b
Compare
b7d6d37
to
3476baf
Compare
3476baf
to
257ab9b
Compare
...aim.metadata.mgt/src/main/java/org/wso2/carbon/identity/claim/metadata/mgt/dao/ClaimDAO.java
Outdated
Show resolved
Hide resolved
...aim.metadata.mgt/src/main/java/org/wso2/carbon/identity/claim/metadata/mgt/dao/ClaimDAO.java
Outdated
Show resolved
Hide resolved
...aim.metadata.mgt/src/main/java/org/wso2/carbon/identity/claim/metadata/mgt/dao/ClaimDAO.java
Outdated
Show resolved
Hide resolved
...aim.metadata.mgt/src/main/java/org/wso2/carbon/identity/claim/metadata/mgt/dao/ClaimDAO.java
Outdated
Show resolved
Hide resolved
…conflict resolution
…cy isUnique property
a97130d
to
3031894
Compare
…cy isUnique property
1226631
to
e271a0d
Compare
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml.j2
Show resolved
Hide resolved
6ae1cb5
to
95ca586
Compare
95ca586
to
6224c1c
Compare
Quality Gate passedIssues Measures |
...ain/java/org/wso2/carbon/identity/claim/metadata/mgt/ClaimMetadataManagementServiceImpl.java
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12241588372
Proposed changes in this pull request
This PR enables flexible attribute uniqueness validation with per-claim configuration of validation scope.
Key Changes
UniquenessScope
Property: Introduces aUniquenessScope
property (enum values:NONE
,WITHIN_USERSTORE
,ACROSS_USERSTORES
) to specify the validation scope within or across user stores.isUnique
is no longer required but is retained for backward compatibility.UniquenessScope
to claims withisUnique
through these endpoints:GET /api/server/v1/claim-dialects/local/claims
POST /api/server/v1/claim-dialects/local/claims
PUT /api/server/v1/claim-dialects/local/claims/{claim-id}
UniquenessScope
; ifisUnique
is present butUniquenessScope
is missing, it defaults to the server-level setting.Related issue
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation