-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for claim-wise uniqueness validation #7106
Merged
AfraHussaindeen
merged 12 commits into
wso2:master
from
AfraHussaindeen:attribute-uniqueness-feature
Dec 12, 2024
Merged
Add support for claim-wise uniqueness validation #7106
AfraHussaindeen
merged 12 commits into
wso2:master
from
AfraHussaindeen:attribute-uniqueness-feature
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 11, 2024 10:08
eb3c3db
to
8a293ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7106 +/- ##
==========================================
+ Coverage 32.02% 32.32% +0.30%
==========================================
Files 41 42 +1
Lines 893 897 +4
Branches 220 221 +1
==========================================
+ Hits 286 290 +4
- Misses 557 587 +30
+ Partials 50 20 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
4 times, most recently
from
November 12, 2024 07:38
9da751d
to
07df2e4
Compare
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 17, 2024 06:20
07df2e4
to
96429a8
Compare
...ures/admin.claims.v1/components/edit/local-claim/edit-additional-properties-local-claims.tsx
Outdated
Show resolved
Hide resolved
...ures/admin.claims.v1/components/edit/local-claim/edit-additional-properties-local-claims.tsx
Outdated
Show resolved
Hide resolved
...ures/admin.claims.v1/components/edit/local-claim/edit-additional-properties-local-claims.tsx
Outdated
Show resolved
Hide resolved
features/admin.claims.v1/components/edit/local-claim/edit-basic-details-local-claims.tsx
Show resolved
Hide resolved
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 25, 2024 04:11
2e05b7b
to
f994bc0
Compare
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 25, 2024 04:13
f994bc0
to
2fa6946
Compare
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 26, 2024 09:07
a5bd5d1
to
7c8f7f2
Compare
AfraHussaindeen
force-pushed
the
attribute-uniqueness-feature
branch
from
November 30, 2024 05:36
299f7cc
to
b48ccc1
Compare
AfraHussaindeen
commented
Dec 2, 2024
features/admin.alternative-login-identifier.v1/pages/alternative-login-identifier-page.tsx
Outdated
Show resolved
Hide resolved
features/admin.alternative-login-identifier.v1/pages/alternative-login-identifier-page.tsx
Outdated
Show resolved
Hide resolved
features/admin.alternative-login-identifier.v1/pages/alternative-login-identifier-page.tsx
Outdated
Show resolved
Hide resolved
features/admin.claims.v1/components/edit/local-claim/edit-basic-details-local-claims.tsx
Outdated
Show resolved
Hide resolved
features/admin.claims.v1/components/edit/local-claim/edit-basic-details-local-claims.tsx
Outdated
Show resolved
Hide resolved
...ures/admin.claims.v1/components/edit/local-claim/edit-additional-properties-local-claims.tsx
Outdated
Show resolved
Hide resolved
...ures/admin.claims.v1/components/edit/local-claim/edit-additional-properties-local-claims.tsx
Show resolved
Hide resolved
features/admin.alternative-login-identifier.v1/pages/alternative-login-identifier-page.tsx
Outdated
Show resolved
Hide resolved
dasuni-30
reviewed
Dec 3, 2024
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce first-class support for attribute uniqueness validation.
Changes to the UI:
A new dropdown will be added to the attribute configuration section under the General tab, giving administrators the flexibility to define the scope of uniqueness validation for each attribute. The dropdown will offer three options:
Note : This dropdown will be displayed only when the uniqueness validation feature is enabled via the deployment.toml
Related Issues
To be merged after
Updated UIs
IS/Asgardeo :
IS only :
additional property
section restrict the addition ofisUnique
property.Asgardeo only :
Checklist
https://github.com/wso2-enterprise/asgardeo-tests/pull/2779
Add documentation for the attribute uniqueness validation configuration docs-is#4911
Add support for claim-wise uniqueness validation carbon-identity-framework#6113
Add UniquenessScope as a first class property for claim management identity-api-server#741
Security checks