Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for claim-wise uniqueness validation #7106

Merged

Conversation

AfraHussaindeen
Copy link
Contributor

@AfraHussaindeen AfraHussaindeen commented Nov 11, 2024

Purpose

Introduce first-class support for attribute uniqueness validation.

Changes to the UI:

A new dropdown will be added to the attribute configuration section under the General tab, giving administrators the flexibility to define the scope of uniqueness validation for each attribute. The dropdown will offer three options:

  • None: No uniqueness validation.
  • Within Userstore: Validation applies only within the selected user store.
  • Across Userstores: Validation is enforced across all user stores.

Note : This dropdown will be displayed only when the uniqueness validation feature is enabled via the deployment.toml

[identity_mgt.user_claim_update.uniqueness]
enable = true

Related Issues

To be merged after

Updated UIs

IS/Asgardeo :

  • Claim's basic details edit section includes a dropdown to configure the uniqueness validation
Screenshot 2024-11-27 at 12 05 10 Screenshot 2024-11-27 at 12 05 25

IS only :

  • The claim's additional property section restrict the addition of isUnique property.
    • When the claim uniqueness valdiation feature is enabled
Screenshot 2024-12-03 at 08 38 05
  • When the claim uniqueness valdiation feature is disabled
Screenshot 2024-11-30 at 10 32 22

Asgardeo only :

  • Aternative login identifier improvement
Screenshot 2024-12-06 at 10 17 47 Screenshot 2024-12-06 at 10 18 13

Checklist

Security checks

@AfraHussaindeen AfraHussaindeen marked this pull request as draft November 11, 2024 09:59
@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from eb3c3db to 8a293ef Compare November 11, 2024 10:08
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.32%. Comparing base (849c07f) to head (32fec6a).
Report is 293 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7106      +/-   ##
==========================================
+ Coverage   32.02%   32.32%   +0.30%     
==========================================
  Files          41       42       +1     
  Lines         893      897       +4     
  Branches      220      221       +1     
==========================================
+ Hits          286      290       +4     
- Misses        557      587      +30     
+ Partials       50       20      -30     
Flag Coverage Δ
@wso2is/core 32.32% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
modules/core/src/models/claim.ts 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from 07df2e4 to 96429a8 Compare November 17, 2024 06:20
@AfraHussaindeen AfraHussaindeen marked this pull request as ready for review November 17, 2024 14:03
@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from 2e05b7b to f994bc0 Compare November 25, 2024 04:11
@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from f994bc0 to 2fa6946 Compare November 25, 2024 04:13
@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from a5bd5d1 to 7c8f7f2 Compare November 26, 2024 09:07
@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch from 299f7cc to b48ccc1 Compare November 30, 2024 05:36
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@AfraHussaindeen AfraHussaindeen merged commit 59a7b7c into wso2:master Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants