Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/healthcheck command#110 #112

Merged
merged 14 commits into from
Jun 21, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Add a command to check if ssh is working after setting up e2e, this basically ssh to the server and run wp --info

Fixes #110

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

I installed chalk dependency

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.

@Khadreal Khadreal marked this pull request as ready for review June 13, 2024 09:03
@Khadreal Khadreal requested review from Miraeld and jeawhanlee June 13, 2024 09:04
backstop.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/features/setup.feature Outdated Show resolved Hide resolved
src/support/steps/steps.ts Outdated Show resolved Hide resolved
utils/commands.ts Outdated Show resolved Hide resolved
@Khadreal Khadreal requested a review from jeawhanlee June 20, 2024 15:15
package.json Outdated Show resolved Hide resolved
utils/commands.ts Outdated Show resolved Hide resolved
@jeawhanlee
Copy link
Contributor

Thanks for the PR @Khadreal, it works as expected.
However, console log on the CLI could be more detailed.
For example we should have a log when the browser setup starts and validate throughout this process with relative log if setup fails or not as well as a log for the auth as well. This is a refinement I believe and an enhancement can be opened for this so we can allow this move forward.
@MathieuLamiot What do you think?

@MathieuLamiot
Copy link
Contributor

💯 Can you open a dedicated issue with those ideas? 🙏 Thanks

@jeawhanlee jeawhanlee merged commit e43c0ea into trunk Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create healthcheck command to run after setup
3 participants