Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Rocket-E2E documentation with latest changes and questions #99

Closed
MathieuLamiot opened this issue Jun 5, 2024 · 7 comments
Closed
Assignees

Comments

@MathieuLamiot
Copy link
Contributor

Update this doc: https://www.notion.so/wpmedia/Rocket-E2E-Test-Automation-using-Cucumber-Playwright-aecad10ae0c14a11aa609881a9d1230b?pvs=4

With details following the questions we had recently:

Maybe consider moving this documentation to a docs folder in the repo directly, to ease its maintenance?

@Khadreal
Copy link
Contributor

Khadreal commented Jun 6, 2024

Updated the doc exxcept for the last item on the list. Do we have to list out each test and expected results ?

@MathieuLamiot
Copy link
Contributor Author

Updated the doc exxcept for the last item on the list. Do we have to list out each test and expected results ?

Listing all that would be overkill I think? What I had in mind was more of a quick test that we would have, to make sure the E2E setup is OK. I'm thinking maybe smoke tests? We could just say "run this command, after 1 minute, you should get this in the console and no errors. It means basic E2E setup is working". WDYT?

@Khadreal
Copy link
Contributor

Khadreal commented Jun 7, 2024

Okay, that makes sense. I'll update the doc with a smoke test and the expected result

@Khadreal
Copy link
Contributor

We don't currently have anything to confirm if basic setup is fine or not, I created a draft PR #112, let me know if this is okay or we need to check for other features

@MathieuLamiot
Copy link
Contributor Author

What I would have in mind for a healthcheck:

  • Check SSH is OK (like you did)
  • Check that the e2e website is accessible, and that the login is OK to get into wp-admin

@MathieuLamiot
Copy link
Contributor Author

@Khadreal Hello, I see this is in progress for more than a week. Are there any blockers or on-going discussions? Thanks

@jeawhanlee
Copy link
Contributor

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants